Removes the inverse flag for contents list component #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanHallam
force-pushed
the
remove-inverse-flag
branch
from
441ec76 to
0052a02
Compare
Reverts #1037 Trello - https://trello.com/c/d9KRrVMb/207-remove-the-contents-list-inverse-option We no longer need to use the contents list component in a topic page header Reverts #1037
vanitabarrett
approved these changes
Sep 5, 2019
JonathanHallam
added a commit
that referenced
this pull request
Sep 5, 2019
* **BREAKING:** Remove the inverse flag for contents list component ([PR #1090](#1090)) * Will stop any inverse flags on the contents list component from working * Set all branded links to correct focus colour ([PR #1088](#1088)) * Fix components focus state spacing ([PR #1054](#1054)) * Allow inset-text to take a block ([PR #1078](#1078))
Merged
JonathanHallam
added a commit
that referenced
this pull request
Sep 5, 2019
* **BREAKING:** Remove the inverse flag for contents list component ([PR #1090](#1090)) * Will stop any inverse flags on the contents list component from working * Set all branded links to correct focus colour ([PR #1088](#1088)) * Fix components focus state spacing ([PR #1054](#1054)) * Allow inset-text to take a block ([PR #1078](#1078))
JonathanHallam
added a commit
that referenced
this pull request
Sep 5, 2019
* **BREAKING:** Remove the inverse flag for contents list component ([PR #1090](#1090)) * Will stop any inverse flags on the contents list component from working * Set all branded links to correct focus colour ([PR #1088](#1088)) * Fix components focus state spacing ([PR #1054](#1054)) * Allow inset-text to take a block ([PR #1078](#1078))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Reverts #1037
Trello - https://trello.com/c/d9KRrVMb/207-remove-the-contents-list-inverse-option
Why
We no longer need to use the contents list component in a topic page header