Allow summary_list to render without borders #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leenagupte
reviewed
Aug 29, 2019
|
@leenagupte it's on my list of things to do. |
vanitabarrett
approved these changes
Aug 29, 2019
andysellick
reviewed
Aug 29, 2019
The Design System implementation of summary_list allows rendering without borders between the summary_list rows: https://design-system.service.gov.uk/components/summary-list/\#summary-list-without-borders However, govuk_publishing_components implementation didn't provide a way of hooking into this. I have now added a 'borderless' field which defaults to 'false', but when 'true' will add the necessary class to remove borders. This is depended on by alphagov/collections-publisher#703
ChrisBAshton
force-pushed
the
summary_list-allow-borderless
branch
from
10a6dc3 to
f455ca6
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Design System implementation of summary_list allows rendering
without borders between the summary_list rows:
https://design-system.service.gov.uk/components/summary-list#summary-list-without-borders
However, govuk_publishing_components implementation didn't provide
a way of hooking into this. I have now added a 'borderless' field
which defaults to 'false', but when 'true' will add the necessary
class to remove borders.
This is depended on by alphagov/collections-publisher#703 (Trello: https://trello.com/c/qXVCEouI/23-show-the-content-title-slug-introduction-description-using-the-summary-component)
Visual Changes
View Changes
https://govuk-publishing-compo-pr-1073.herokuapp.com/component-guide/summary_list