Normalise falsey values to nil to prevent lang="false"
#1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
injms
force-pushed
the
subscription-links-translation-patch
branch
from
b625347 to
cd26bfd
Compare
tijmenb
reviewed
Aug 6, 2019
app/views/govuk_publishing_components/components/_subscription-links.html.erb
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Checks that the locale attributes being passed into the subscription links components are falsey - if falsey then
nilis used.Why
When a
falsewas being used as a parameter in the subscription components, it was being cast and used as a string - leading tolang="false". Not a big deal, since (according to the spec) this should be ignored, but worth fixing.Visual Changes
None.
View Changes
https://govuk-publishing-compo-pr-1021.herokuapp.com/