-
Notifications
You must be signed in to change notification settings - Fork 20
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add cross domain linking to main GA property
- we already have cross domain linking configured for a second GA property. The way this works is that the analytics code is passed the property and the list of domains, and this is created and linking set up all in one go, using the addLinkedTrackerDomain function - however, we now want to add cross domain tracking into the main property as well, for a different set of domains (well, one - for the new DI accounts system). We could call the same function, but by that point we've already created the property, so instead the code has been modified to check for the presence of linked domains for the primary property and initialise the linker in the function for creating the main property - all of this is a bit of a spaghetti - ideally we'd have one clear function that creates a property and optionally configures cross domain linking, and we'd call that as many times as there are properties - also tried to clarify some of the variable names in init.js, but as some of this is currently being called from accounts I don't want to introduce breaking changes
- Loading branch information
1 parent
31e89c4
commit 78a0a63
Showing
3 changed files
with
22 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters