Merge pull request #4225 from alphagov/fix-label-styles

Fix inconsistent search label appearance
alphagov · Sep 16, 2024 · 47ab761 · 47ab761
2 parents 33d2a29 + 274fba5
commit 47ab761
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/app/assets/stylesheets/govuk_publishing_components/components/_search.scss b/app/assets/stylesheets/govuk_publishing_components/components/_search.scss
@@ -229,7 +229,7 @@ $large-input-size: 50px;
   }
 }
 
-.gem-c-search__label--white {
+.govuk-label.gem-c-search__label--white {
   color: govuk-colour("white");
 }
 

diff --git a/app/views/govuk_publishing_components/components/_search.html.erb b/app/views/govuk_publishing_components/components/_search.html.erb
@@ -1,5 +1,6 @@
 <%
   add_gem_component_stylesheet("search")
+  add_gem_component_stylesheet("label")
 
   shared_helper = GovukPublishingComponents::Presenters::SharedHelper.new(local_assigns)
   heading_helper = GovukPublishingComponents::Presenters::HeadingHelper.new(local_assigns)
@@ -51,10 +52,8 @@
     end
   end
 %>
-
 <div class="<%= classes.join(" ") %>" data-module="gem-toggle-input-class-on-focus">
   <% if wrap_label_in_a_heading %>
-    <% add_gem_component_stylesheet("label") %>
     <%= content_tag(shared_helper.get_heading_level, class: "govuk-!-margin-0") do %>
       <%= tag_label %>
     <% end %>
-Original file line number
+Diff line change
@@ Expand Up / @@ -229,7 +229,7 @@ $large-input-size: 50px; @@
       }
     }
-    .gem-c-search__label--white {
+    .govuk-label.gem-c-search__label--white {
       color: govuk-colour("white");
     }
@@ Expand Down @@