Rename header name constants #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes: - `ACCOUNT_SESSION_REQUEST_HEADER_NAME` to `ACCOUNT_SESSION_INTERNAL_HEADER_NAME` - `ACCOUNT_SESSION_RESPONSE_HEADER_NAME` to `ACCOUNT_SESSION_HEADER_NAME` - `ACCOUNT_END_SESSION_RESPONSE_HEADER_NAME` to `ACCOUNT_END_SESSION_HEADER_NAME` `"GOVUK-Account-Session"` is the externally available header's name both for requests and responses. It only in gets changed by Rails in the controller, where it becomes `"HTTP_GOVUK_ACCOUNT_SESSION"`. So it makes sense to have `"GOVUK-Account-Session"` in a constant called `ACCOUNT_SESSION_HEADER_NAME` and have `"HTTP_GOVUK_ACCOUNT_SESSION"` in a constant called `ACCOUNT_SESSION_INTERNAL_HEADER_NAME`. Similarly, this also removes the `RESPONSE` qualifier from the constant that holds `"GOVUK-Account-End-Session"` so that it now becomes simply `ACCOUNT_END_SESSION_HEADER_NAME`.
barrucadu
approved these changes
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes:
ACCOUNT_SESSION_REQUEST_HEADER_NAMEtoACCOUNT_SESSION_INTERNAL_HEADER_NAMEACCOUNT_SESSION_RESPONSE_HEADER_NAMEtoACCOUNT_SESSION_HEADER_NAMEACCOUNT_END_SESSION_RESPONSE_HEADER_NAMEtoACCOUNT_END_SESSION_HEADER_NAME"GOVUK-Account-Session"is the externally available header's name bothfor requests and responses. It only in gets changed by Rails in the
controller, where it becomes
"HTTP_GOVUK_ACCOUNT_SESSION".So it makes sense to have
"GOVUK-Account-Session"in a constant calledACCOUNT_SESSION_HEADER_NAMEand have"HTTP_GOVUK_ACCOUNT_SESSION"ina constant called
ACCOUNT_SESSION_INTERNAL_HEADER_NAME.Similarly, this also removes the
RESPONSEqualifier from the constantthat holds
"GOVUK-Account-End-Session"so that it now becomes simplyACCOUNT_END_SESSION_HEADER_NAME.