Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the capitalisation of trackPageview #465

Merged
merged 1 commit into from
Jul 16, 2018
Merged

Correct the capitalisation of trackPageview #465

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/analytics.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,8 +227,8 @@ email address was removed, `[date]` if a date was removed, or `[postcode]`
if a postcode was removed.

We have to parse all arguments which means that if you don't pass a path to
`trackPageView` to track the current page we have to extract the current page
and parse it, turning all `trackPageView` calls into ones with a path argument.
`trackPageview` to track the current page we have to extract the current page
and parse it, turning all `trackPageview` calls into ones with a path argument.
We use `window.location.href.split('#')[0]` as the default path when one is
not provided. The original behaviour would have been to ignore the anchor
part of the URL anyway so this doesn't change the behaviour other than to make
Expand Down