Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GOVUK.ShowHideContent JavaScript #315

Merged
merged 12 commits into from
Sep 5, 2016
Merged

Add GOVUK.ShowHideContent JavaScript #315

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
1c0db7f
Add GOVUK.ShowHideContent
colinrotherham Aug 10, 2016
51de396
Add clarity to GOVUK.ShowHideContent docs
colinrotherham Aug 19, 2016
ba6936e
Slight performance tweak to GOVUK.ShowHideContent
colinrotherham Aug 19, 2016
77268de
Use Standard to format JS
gemmaleigh Aug 19, 2016
cbbcb38
Use Standard to lint the spec
gemmaleigh Aug 19, 2016
63362d8
Use closest() rather than parent()
gemmaleigh Aug 22, 2016
6caa441
Remove unused class js-toggle-showhide from spec
gemmaleigh Aug 23, 2016
3999832
Run handleRadioContent only on controlling radios
tombye Aug 23, 2016
9d9b3c6
Add fixes for standard JS errors
tombye Aug 23, 2016
91a8ed7
Re-point paths to jasmine runner files
tombye Aug 24, 2016
420b23d
Only bind events to controlling selection buttons
tombye Aug 24, 2016
a8ae9ee
Remove parenthesis from return expression
tombye Aug 24, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion javascripts/govuk/show-hide-content.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
// Escape name attribute for use in DOM selector
function escapeElementName (str) {
var result = str.replace('[', '\\[').replace(']', '\\]')
return (result)
return result
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could just return the above expression, result isn't used anywhere else so just keep it simple..

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed and done.

}

// Adds ARIA attributes to control + associated content
Expand Down