Bump version to 4.14.0 #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - Configurable duration (in days) for AB Test cookie. | ||
| - Add assignment of jQuery explicitly so it's consistent with other modules. | ||
| - Allow base scripts to run within a module loader. | ||
| - Force push tracking branch on new version. |
There was a problem hiding this comment.
The audience of the change log is people consuming govuk_frontend_toolkit, so we don't need to mention an internal change like the tracking branch.
There was a problem hiding this comment.
Ahh right.. sorry
There was a problem hiding this comment.
Can probably remove Add assignment of jQuery explicitly so it's consistent with other modules. as well as that was just an ancillary piece of work.
|
Couple of comments on the changelog, otherwise it looks good. Sorry if the changelog comments come across a bit nit-picky! It's the main way people using FET, from all over gov, can see whats changed version to version, and it's worth spending a bit of time making it as user friendly as possible :) |
|
@dsingleton comments are much appreciated.. |
|
|
||
| - Allow use of multiple GA customDimensionIndex. See [this section](https://github.com/alphagov/govuk_frontend_toolkit/blob/master/docs/javascript.md#using-google-custom-dimensions-with-your-own-statistical-model) of the documentation for more information. | ||
| - Configurable duration (in days) for AB Test cookie. See [this section](https://github.com/alphagov/govuk_frontend_toolkit/blob/master/docs/javascript.md#multivariate-test-framework) of the documentation for more information. | ||
| - Add assignment of jQuery explicitly so it's consistent with other modules. |
There was a problem hiding this comment.
I think it might have gotten lost in force-pushes, but I agree with @robinwhittleton that "Add assignment of jQuery explicitly" is an internal change, which doesn't affect consumers, so we can omit it from the changelog too 👍
There was a problem hiding this comment.
Ok will exclude it
- Allow use of multiple GA customDimensionIndex. - Configurable duration (in days) for AB Test cookie. - Add assignment of jQuery explicitly so it's consistent with other modules. - Allow base scripts to run within a module loader. - Force push tracking branch on new version.
|
👏 thanks for the extra effort with the change log :) |
ikennaokpala
added a commit
to alphagov/smart-answers
that referenced
this pull request
Jul 22, 2016
This commit bumps the front-end toolkit from 4.8.0 to 4.14.0 as a result of the recent update to the front-end toolkit. * alphagov/govuk_frontend_toolkit#296 * alphagov/govuk_frontend_toolkit#294 * alphagov/govuk_frontend_toolkit#292
ikennaokpala
added a commit
to alphagov/smart-answers
that referenced
this pull request
Jul 26, 2016
This commit bumps the front-end toolkit from 4.8.0 to 4.14.0 as a result of the recent update to the front-end toolkit. * alphagov/govuk_frontend_toolkit#296 * alphagov/govuk_frontend_toolkit#294 * alphagov/govuk_frontend_toolkit#292
ikennaokpala
added a commit
to alphagov/smart-answers
that referenced
this pull request
Jul 26, 2016
This commit bumps the front-end toolkit from 4.8.0 to 4.14.0 as a result of the recent update to the front-end toolkit. * alphagov/govuk_frontend_toolkit#296 * alphagov/govuk_frontend_toolkit#294 * alphagov/govuk_frontend_toolkit#292 SmartAnswers makes use of the following files from the frontend_toolkit: Stylesheets: - _conditionals.scss - _typography.scss - _colours.scss - _shims.scss - design-patterns/_buttons.scss - _grid_layout.scss Javascript: - govuk/multivariate-test Having reviewed the diff between 4.8.0 and 4.14.0 alphagov/govuk_frontend_toolkit@0cfc216...37d23c1. This diff composes of 82 commits, 34 Merge Commits and 48 concrete commits. I gone through each tracing the possible areas that this might affect smart answers. To the best of my knowledge I have found only cosmetic changes to the following files. Stylesheets: - _typography.scss e05ca517 , 70f53d27c - _colors.scss 11798945a , 3853a726c , 0052024b4b9 , 984d53292 , 2180a72e4 UI examination was carried by Anika and myself and we found nothing of concern. Already existing unit, regression and integration tests passed, giving assurance that the aforementioned commit/changes have had no (interfering) affect to the transit route or flow or other routes within check uk visa or other smart answers.
ikennaokpala
added a commit
to alphagov/smart-answers
that referenced
this pull request
Jul 27, 2016
This commit bumps the front-end toolkit from 4.8.0 to 4.14.0 as a result of the recent update to the front-end toolkit. * alphagov/govuk_frontend_toolkit#296 * alphagov/govuk_frontend_toolkit#294 * alphagov/govuk_frontend_toolkit#292 SmartAnswers makes use of the following files from the frontend_toolkit: Stylesheets: - _conditionals.scss - _typography.scss - _colours.scss - _shims.scss - design-patterns/_buttons.scss - _grid_layout.scss Javascript: - govuk/multivariate-test Having reviewed the diff between 4.8.0 and 4.14.0 alphagov/govuk_frontend_toolkit@0cfc216...37d23c1. This diff composes of 82 commits, 34 Merge Commits and 48 concrete commits. I gone through each tracing the possible areas that this might affect smart answers. To the best of my knowledge I have found only cosmetic changes to the following files. Stylesheets: - _typography.scss e05ca517 , 70f53d27c - _colors.scss 11798945a , 3853a726c , 0052024b4b9 , 984d53292 , 2180a72e4 UI examination was carried by Anika and myself and we found nothing of concern. Already existing unit, regression and integration tests passed, giving assurance that the aforementioned commit/changes have had no (interfering) affect to the transit route or flow or other routes within check uk visa or other smart answers.
ikennaokpala
added a commit
to alphagov/smart-answers
that referenced
this pull request
Jul 27, 2016
This commit bumps the front-end toolkit from 4.8.0 to 4.14.0 as a result of the recent update to the front-end toolkit. * alphagov/govuk_frontend_toolkit#296 * alphagov/govuk_frontend_toolkit#294 * alphagov/govuk_frontend_toolkit#292 SmartAnswers makes use of the following files from the frontend_toolkit: Stylesheets: - _conditionals.scss - _typography.scss - _colours.scss - _shims.scss - design-patterns/_buttons.scss - _grid_layout.scss Javascript: - govuk/multivariate-test Having reviewed the diff between 4.8.0 and 4.14.0 alphagov/govuk_frontend_toolkit@0cfc216...37d23c1. This diff composes of 82 commits, 34 Merge Commits and 48 concrete commits. I gone through each tracing the possible areas that this might affect smart answers. To the best of my knowledge I have found only cosmetic changes to the following files. Stylesheets: - _typography.scss e05ca517 , 70f53d27c - _colors.scss 11798945a , 3853a726c , 0052024b4b9 , 984d53292 , 2180a72e4 UI examination was carried by Anika and myself and we found nothing of concern. Already existing unit, regression and integration tests passed, giving assurance that the aforementioned commit/changes have had no (interfering) affect to the transit route or flow or other routes within check uk visa or other smart answers.
ikennaokpala
added a commit
to alphagov/smart-answers
that referenced
this pull request
Jul 27, 2016
This commit bumps the front-end toolkit from 4.8.0 to 4.14.0 as a result of the recent update to the front-end toolkit. * alphagov/govuk_frontend_toolkit#296 * alphagov/govuk_frontend_toolkit#294 * alphagov/govuk_frontend_toolkit#292 SmartAnswers makes use of the following files from the frontend_toolkit: Stylesheets: - _conditionals.scss - _typography.scss - _colours.scss - _shims.scss - design-patterns/_buttons.scss - _grid_layout.scss Javascript: - govuk/multivariate-test Having reviewed the diff between 4.8.0 and 4.14.0 alphagov/govuk_frontend_toolkit@0cfc216...37d23c1. This diff composes of 82 commits, 34 Merge Commits and 48 concrete commits. I gone through each tracing the possible areas that this might affect smart answers. To the best of my knowledge I have found only cosmetic changes to the following files. Stylesheets: - _typography.scss e05ca517 , 70f53d27c - _colors.scss 11798945a , 3853a726c , 0052024b4b9 , 984d53292 , 2180a72e4 UI examination was carried by Anika and myself and we found nothing of concern. Already existing unit, regression and integration tests passed, giving assurance that the aforementioned commit/changes have had no (interfering) affect to the transit route or flow or other routes within check uk visa or other smart answers.
ikennaokpala
added a commit
to alphagov/smart-answers
that referenced
this pull request
Jul 28, 2016
This commit bumps the front-end toolkit from 4.8.0 to 4.14.0 as a result of the recent update to the front-end toolkit. * alphagov/govuk_frontend_toolkit#296 * alphagov/govuk_frontend_toolkit#294 * alphagov/govuk_frontend_toolkit#292 SmartAnswers makes use of the following files from the frontend_toolkit: Stylesheets: - _conditionals.scss - _typography.scss - _colours.scss - _shims.scss - design-patterns/_buttons.scss - _grid_layout.scss Javascript: - govuk/multivariate-test Having reviewed the diff between 4.8.0 and 4.14.0 alphagov/govuk_frontend_toolkit@0cfc216...37d23c1. This diff composes of 82 commits, 34 Merge Commits and 48 concrete commits. I gone through each tracing the possible areas that this might affect smart answers. To the best of my knowledge I have found only cosmetic changes to the following files. Stylesheets: - _typography.scss e05ca517 , 70f53d27c - _colors.scss 11798945a , 3853a726c , 0052024b4b9 , 984d53292 , 2180a72e4 UI examination was carried by Anika and myself and we found nothing of concern. Already existing unit, regression and integration tests passed, giving assurance that the aforementioned commit/changes have had no (interfering) affect to the transit route or flow or other routes within check uk visa or other smart answers.
ikennaokpala
added a commit
to alphagov/smart-answers
that referenced
this pull request
Jul 28, 2016
This commit bumps the front-end toolkit from 4.8.0 to 4.14.0 as a result of the recent update to the front-end toolkit. * alphagov/govuk_frontend_toolkit#296 * alphagov/govuk_frontend_toolkit#294 * alphagov/govuk_frontend_toolkit#292 SmartAnswers makes use of the following files from the frontend_toolkit: Stylesheets: - _conditionals.scss - _typography.scss - _colours.scss - _shims.scss - design-patterns/_buttons.scss - _grid_layout.scss Javascript: - govuk/multivariate-test Having reviewed the diff between 4.8.0 and 4.14.0 alphagov/govuk_frontend_toolkit@0cfc216...37d23c1. This diff composes of 82 commits, 34 Merge Commits and 48 concrete commits. I gone through each tracing the possible areas that this might affect smart answers. To the best of my knowledge I have found only cosmetic changes to the following files. Stylesheets: - _typography.scss e05ca517 , 70f53d27c - _colors.scss 11798945a , 3853a726c , 0052024b4b9 , 984d53292 , 2180a72e4 UI examination was carried by Anika and myself and we found nothing of concern. Already existing unit, regression and integration tests passed, giving assurance that the aforementioned commit/changes have had no (interfering) affect to the transit route or flow or other routes within check uk visa or other smart answers.
ikennaokpala
added a commit
to alphagov/smart-answers
that referenced
this pull request
Jul 28, 2016
This commit bumps the front-end toolkit from 4.8.0 to 4.14.0 as a result of the recent update to the front-end toolkit. * alphagov/govuk_frontend_toolkit#296 * alphagov/govuk_frontend_toolkit#294 * alphagov/govuk_frontend_toolkit#292 SmartAnswers makes use of the following files from the frontend_toolkit: Stylesheets: - _conditionals.scss - _typography.scss - _colours.scss - _shims.scss - design-patterns/_buttons.scss - _grid_layout.scss Javascript: - govuk/multivariate-test Having reviewed the diff between 4.8.0 and 4.14.0 alphagov/govuk_frontend_toolkit@0cfc216...37d23c1. This diff composes of 82 commits, 34 Merge Commits and 48 concrete commits. I gone through each tracing the possible areas that this might affect smart answers. To the best of my knowledge I have found only cosmetic changes to the following files. Stylesheets: - _typography.scss e05ca517 , 70f53d27c - _colors.scss 11798945a , 3853a726c , 0052024b4b9 , 984d53292 , 2180a72e4 UI examination was carried by Anika and myself and we found nothing of concern. Already existing unit, regression and integration tests passed, giving assurance that the aforementioned commit/changes have had no (interfering) affect to the transit route or flow or other routes within check uk visa or other smart answers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this PR alphagov/smart-answers#2655
#4.14.0