Skip to content

Commit

Permalink
Remove grunt-shell dependency and use npm script (#327)
Browse files Browse the repository at this point in the history
* Remove grunt-shell dependency and use npm script

* Use --silent here to reduce NPM error message output

This then outputs `npm ERR! Test failed.  See above for more details.`.
  • Loading branch information
NickColley authored and robinwhittleton committed Sep 19, 2016
1 parent e03e7f5 commit 10f7112
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 13 deletions.
13 changes: 2 additions & 11 deletions Gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,25 +49,16 @@ module.exports = function(grunt) {
loadPath: [
'./stylesheets'
],
style: 'nested',
style: 'nested'
}
},
},
shell: {
multiple: {
command: [
'bundle',
'bundle exec govuk-lint-sass stylesheets'
].join('&&')
}
}
});

grunt.loadNpmTasks('grunt-contrib-clean');
grunt.loadNpmTasks('grunt-contrib-jasmine');
grunt.loadNpmTasks('grunt-contrib-sass');
grunt.loadNpmTasks('grunt-shell');

grunt.registerTask('test', ['sass', 'clean', 'jasmine', 'shell']);
grunt.registerTask('test', ['sass', 'clean', 'jasmine']);
grunt.registerTask('default', ['test']);
};
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@
"grunt-contrib-clean":"~0.6.0",
"grunt-contrib-jasmine": "^1.0.0",
"grunt-contrib-sass": "0.7.4",
"grunt-shell": "^1.1.2",
"jquery": "~1.11.3"
},
"scripts": {
"test": "node_modules/.bin/grunt test"
"test": "grunt test && npm run lint --silent",
"lint": "bundle && bundle exec govuk-lint-sass stylesheets"
}
}

0 comments on commit 10f7112

Please sign in to comment.