Allow create release build stage to fail without failing the build #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gemmaleigh
changed the title
Ensure Travis aborts without creating a release if version hasn't changed. If it has changed, proceed to create release. Otherwise exit.
This should be allowed to fail, without marking the entire build as a failure - as we’re only creating a release on tagged commits - once the version.txt file in packages/govuk-elements-sass/ has been updated. The check-release-version script will exit if the version hasn’t been changed.
This ensures all build scripts are moved into the scripts directory.
gemmaleigh
force-pushed
the
allow-release-deployment-to-fail
branch
from
f1697ad to
273d855
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a script to check if the VERSION.txt file has been updated in
packages/govuk-elements-sass/, if it hasn't been updated - exit without creating a release.Allow failures for the "create release" build stage.
This should be allowed to fail - without marking the entire build as a
failure - as we’re only deploying when the packages directory has been
updated.
This can be seen working here -
where the build stage "create release" fails (and that's fine, that's what we expect unless we've updated the packages directory and updated VERSION.txt to release a new version) but the overall build succeeds.