Revert changes to dependencies and devDependencies #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the dependencies to run the govuk-elements app into devDependencies. Ensure that the dependencies for the govuk-elements-sass package are in dependencies. For this to work on Heroku, production mode will need to be disabled.
|
Belated 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the dependencies to run the govuk-elements app into
devDependencies.
Ensure that the dependencies for the govuk-elements-sass package are in
dependencies.
This reverts the change made on Friday, when trying to debug the node_modules cache issue with Yarn and Heroku: yarnpkg/yarn#1981
For this to work on Heroku, production mode will need to be disabled.