-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recognise Larry’s contribution to the Cabinet Office #373
Conversation
As Chief Mouser to the Cabinet Office (https://www.gov.uk/government/history/10-downing-street#larry-chief-mouser) Larry plays a vital part in the day-to-day running of government. Given that we’re celebrating 100 years of the Cabinet Office this month (https://www.nationalarchives.gov.uk/cabinet-office-100) it makes sense to celebrate one of its most famous postings in a small way in this style guide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly a file to cleanup, but otherwise 👍
@@ -70,7 +70,7 @@ <h3 class="heading-medium" id="images">Images</h3> | |||
<img src="/public/images/examples/3by2.jpg" alt="3:2"> | |||
</div> | |||
<div class="column-one-half"> | |||
<img src="/public/images/examples/pm.jpg" alt=""> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to remove this file, or is it used elsewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be used in prototypes so removing it would potentially be a breaking change. Might as well leave it in for the time being.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we know something should be removed at some point later, we should deprecate it. Do we have any official deprecation rules?
Yay, we should include an alt tag so that assistive tech users know it's Larry 😻 |
# 5.1.1 - Update the alpha, beta and discovery colours to $govuk-blue to match the updated phase banner ([PR #370](alphagov/govuk_frontend_toolkit#370)) - Fix radio button show/hide behaviour when used outside a form ([PR #375](alphagov/govuk_frontend_toolkit#375)) - Fix a "Stick at top when scrolling" component bug related to scroll anchoring in Chrome 56+ ([PR #376](alphagov/govuk_frontend_toolkit#376)) - Minor travis fixes ([PR #373](alphagov/govuk_frontend_toolkit#373)) # 5.1.0 - Allow custom options when tracking events ([PR #365](alphagov/govuk_frontend_toolkit#365)) # 5.0.3 - Change HMRC and DEFRA text colours for improved contrast ([PR #368](alphagov/govuk_frontend_toolkit#368))
As Chief Mouser to the Cabinet Office Larry plays a vital part in the day-to-day running of government. Given that we’re celebrating 100 years of the Cabinet Office this month it makes sense to celebrate one of its most famous postings in a small way in this style guide.