Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the phase banner examples, the phase tag is now $govuk-blue #364

Merged
merged 4 commits into from
Nov 29, 2016
Merged

Update the phase banner examples, the phase tag is now $govuk-blue #364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3dab52b
Don't pass a state to the phase banner mixin
gemmaleigh Nov 29, 2016
cda3a94
Add a phase-banner class and update examples
gemmaleigh Nov 29, 2016
e3adb31
Switch to govuk-blue for phase banners
Nov 29, 2016
f2a0ebb
Add documentation around new `phase-banner` class
Nov 29, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/views/guide_alpha_beta.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,10 @@ <h3 class="heading-medium" id="creating-phase-banners">Creating alpha and beta b
Use the GOV.UK Sass phase banner mixin &ndash; find this in the GOV.UK frontend toolkit <a href="https://github.com/alphagov/govuk_frontend_toolkit/blob/master/stylesheets/design-patterns/_alpha-beta.scss">alpha-beta.scss</a> file.
</p>

<p class="text">
If you’ve previously used <code>phase-banner-alpha</code> or <code>phase-banner-beta</code> classes in your markup you should change them to <code>phase-banner</code>.
</p>

<p>
<a href="https://designpatterns.hackpad.com/Alpha-and-beta-banners-HpbaBjaYRSJ" rel="external">
Discuss alpha and beta banners on the design patterns Hackpad
Expand Down
2 changes: 1 addition & 1 deletion app/views/includes/phase_banner.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<div class="phase-banner-alpha">
<div class="phase-banner">
<p>
<strong class="phase-tag">ALPHA</strong>
<span>This is a new service – your <a href="https://designpatterns.hackpad.com/GOV.UK-elements-feedback-sKrDyQxcfA2">feedback</a> will help us to improve it.</span>
Expand Down
2 changes: 1 addition & 1 deletion app/views/snippets/phase_banner_alpha.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<div class="phase-banner-alpha">
<div class="phase-banner">
<p>
<strong class="phase-tag">ALPHA</strong>
<span>This is a new service – your <a href="#">feedback</a> will help us to improve it.</span>
Expand Down
4 changes: 2 additions & 2 deletions app/views/snippets/phase_banner_beta.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<div class="phase-banner-beta">
<div class="phase-banner">
<p>
<strong class="phase-tag">BETA</strong>
<span>This is a new service – your <a href="#">feedback</a> will help us to improve it.</span>
</p>
</div>
</div>
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"node": ">=4.4.7"
},
"dependencies": {
"govuk_frontend_toolkit": "^5.0.1"
"govuk_frontend_toolkit": "^5.0.2"
},
"devDependencies": {
"body-parser": "^1.14.1",
Expand Down
9 changes: 6 additions & 3 deletions public/sass/elements/_phase-banner.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
// Phase banners
// ==========================================================================

.phase-banner-alpha {
@include phase-banner($state: alpha);
.phase-banner {
@include phase-banner();
}

// These classnames are deprecated,
// they will be removed in a future version of GOV.UK elements
.phase-banner-alpha,
.phase-banner-beta {
@include phase-banner($state: beta);
@include phase-banner();
}