Update code example colours to improve contrast and readability #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gemmaleigh
reviewed
Oct 27, 2016
| word-spacing: normal; | ||
| word-break: normal; | ||
| // Wrap lines of code rather than overflowing | ||
| white-space: pre-wrap; /* css-3 */ |
There was a problem hiding this comment.
Can we use scss comments consistently please?
// rather than /* so these don't wind up in the compiled css.
|
Thanks for all your work on this @edwardhorsford! |
- Use variables where they are defined by the govuk_frontend_toolkit - Use Sass comments - Each selector in a comma sequence should be on its own single line
|
Any chance you could provide this as a .thTheme file? |
|
@smlombardi Sorry, we don't have it as a theme. The colours used are available in this PR though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does the pull request solve?
This PR adjusts the colours used in example code blocks so that they are each 4.5:1 or greater contrast against the background. This will improve the readability for those who struggle with low contrast.
Demo page with highlighting on many languages. username: syntax password: highlighting
What does it do?
How has this been tested?
Screenshots (if appropriate):
HTML Before:
HTML After:
CSS / SCSS isn't currently used in any examples on Elements, but likely will in future GOV.UK Frontend work.
CSS Before:
CSS After:
What type of change is it?
Put an
xin all the boxes that applyNot done
Highlighting for markdown snippets isn't great - I don't think we have any current cases where it's needed, so haven't done anything to adjust it specifically yet.