Reorder grunt tasks, remove the Procfile, remove grunt-shell dependency #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gemmaleigh
force-pushed
the
add-test-for-procfile
branch
from
29383a9 to
8ed1a0d
Compare
| 'lint', | ||
| 'Use govuk-scss-lint to lint the sass files', | ||
| 'test', | ||
| '', |
gemmaleigh
force-pushed
the
add-test-for-procfile
branch
from
b60011e to
06b820e
Compare
| 'encode_snippets', | ||
| 'Encode HTML snippets', | ||
| function () { | ||
| grunt.task.run('htmlentities') | ||
| } | ||
| ) | ||
|
|
||
| // Test | ||
| grunt.registerTask( |
There was a problem hiding this comment.
Might be my ignorance but do these need to be this verbose?
http://gruntjs.com/api/grunt.task
e.g.
task.registerTask('test', ['jshint', 'test_default', 'test_default_success']);
|
cc. @robinwhittleton, @NickColley. This also includes the removal of the grunt-shell dependency, to match the govuk_frontend_toolkit. |
gemmaleigh
changed the title
NickColley
reviewed
Sep 19, 2016
| } | ||
| ) | ||
| // Encode HTML snippets | ||
| grunt.registerTask('encode_snippets', ['htmlentities', 'htmlentities_success']) |
There was a problem hiding this comment.
Minor: You don't expect to see underscores in idomatic JavaScript that much so it feels odd to see encode_snippets instead of encode-snippet etc but it's not a big deal
gemmaleigh
force-pushed
the
add-test-for-procfile
branch
from
ed21b72 to
7d284b2
Compare
- Add comments to each of the test tasks - Make tasks less verbose - Rename Grunt tasks to use hyphens not underscores
Also use standard —fix to fix indentation.
https://devcenter.heroku.com/articles/nodejs-support#default-web-process -type If no Procfile is present in the root directory of your app during the build process, your web process will be started by running npm start, a script you can specify in package.json.
This then outputs `npm ERR! Test failed. See above for more details.`, rather than the more verbose error.
gemmaleigh
force-pushed
the
add-test-for-procfile
branch
from
7d284b2 to
43df27c
Compare
gemmaleigh
force-pushed
the
add-test-for-procfile
branch
from
8c76080 to
38b1f24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
This PR:
[*] If no Procfile is present in the root directory of your app during the build process, your web process will be started by running
npm start, specified in package.json.What type of change is it?
Put an
xin all the boxes that apply