Make sure the test task fails if scss lint fails #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `grunt test` is run, run the lint task first to lint the sass files. Then test that the default task works.
gemmaleigh
force-pushed
the
get-travis-to-check-grunt-lint-task
branch
from
312a134 to
eeaa0a9
Compare
Each selector in a comma sequence should be on its own single line
joelanman
pushed a commit
to joelanman/govuk_elements
that referenced
this pull request
Jun 13, 2016
# 4.9.0 - Add websafe organisation colours - Split colours into two files with backwards-compatible colours.scss replacement # 4.8.2 - Add GOV.UK lint to lint scss files (PR alphagov#260) - Remove reference to old colour palette (PR alphagov#256) - Fix link to GOV.UK elements - tabular data # 4.8.1 - Update DEFRA brand colour to new green (PR alphagov#249) # 4.8.0 - Pass cohort name to analytics when using multivariate test (PR alphagov#251) # 4.7.0 - Add 'mailto' tracking to GOV.UK Analytics (PR alphagov#244)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
grunt testis run, run the lint task first to lint the sassfiles.
Then test that the default task works.
This should fail and then pass once #243 is merged.