Fix the summary arrow in recent Firefox #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a pretty hacky fix so I’ve tried to describe it as accurately as possible in the comments. It can be removed if either of the following happens: * Mozilla fixes their summary arrow with display: inline-block * Mozilla remove their support for @-moz-document Fixes #221
|
What does everyone else think. Worth adding? |
|
Hang on, that breaks in older versions of Firefox. Will revise. |
Older Firefoxes still use the polyfill, and so don’t want display: list-item. The JS sets a tabindex attribute, so we can infer that the native version won’t have that.
robinwhittleton
force-pushed
the
firefox-summary-arrow
branch
from
7e8f227 to
2abbcd4
Compare
@csswizardry proposed a shame.css convention (http://csswizardry.com/2013/04/shame-css/). This hack certainly merits starting one for elements.
|
I've tested this in Firefox Developer Edition and it works nicely, screenshots below. What is currently in master:
This branch:
thanks @robinwhittleton 👏 |
gemmaleigh
added a commit
that referenced
this pull request
May 25, 2016
# 1.2.0 - Add MIT License (PR #236) - Create latest release branch as an alias of the latest release (PR #232) - Create new app to preview govuk elements sass releases (PR #219) - Fix the summary arrow in recent Firefox (PR #227) - Remove button padding overriding the govuk_frontend_toolkit (PR #230) - Don't copy the govuk_frontend_toolkit's images into an icons folder (PR #223) - Fix path for rails and node environments (PR #234) - Import the govuk_frontend_toolkit url-helpers partial - If image-url is not defined (if we are not in a Rails environment), then set a path to /public/images
gemmaleigh
added a commit
that referenced
this pull request
May 25, 2016
# 1.2.0 - Add MIT License (PR #236) - Create latest release branch as an alias of the latest release (PR #232) - Create new app to preview govuk elements sass releases (PR #219) - Fix the summary arrow in recent Firefox (PR #227) - Remove button padding overriding the govuk_frontend_toolkit (PR #230) - Don't copy the govuk_frontend_toolkit's images into an icons folder (PR #223) - Fix path for rails and node environments (PR #234) - Import the govuk_frontend_toolkit url-helpers partial - If image-url is not defined (if we are not in a Rails environment), then set a path to /public/images
robinwhittleton
pushed a commit
that referenced
this pull request
May 26, 2016
# 1.2.0 - Add MIT License (PR #236) - Create latest release branch as an alias of the latest release (PR #232) - Create new app to preview govuk elements sass releases (PR #219) - Fix the summary arrow in recent Firefox (PR #227) - Remove button padding overriding the govuk_frontend_toolkit (PR #230) - Don't copy the govuk_frontend_toolkit's images into an icons folder (PR #223) - Fix path for rails and node environments (PR #234) - Import the govuk_frontend_toolkit url-helpers partial - If image-url is not defined (if we are not in a Rails environment), then set a path to /public/images - Fix the skip link in Safari (PR #225)
Merged
joelanman
pushed a commit
to joelanman/govuk_elements
that referenced
this pull request
Jun 13, 2016
# 4.5.0 - Find and auto-start JavaScript modules from markup: `data-module="module-name"`(PR alphagov#227) # 4.4.0 - Add helpers partial for functions - Add px to em function and documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty hacky fix so I’ve tried to describe it as accurately as possible in the comments. It can be removed if either of the following happens:
display: inline-block@-moz-documentFixes #221