Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guidance on using turquoise backgrounds #214

Closed
wants to merge 2 commits into from

Conversation

sanjaypoyzer
Copy link

Fixes the problem discussed in issue #200.

Fixes the problem discussed in issue alphagov#200.

<p>
Note that the white text on turquoise background only passes accessibility standards if the font size is at least 18px, or 14px bold.
</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'accessibility standards' is a little vague, could this be revised to "only meets [
WCAG2 Level AA, with a contrast ratio of 3:1 for large text - when the font size is at least 18px, or 14px bold.

@sanjaypoyzer
Copy link
Author

@gemmaleigh Not quite sure why the CI failed there...

@gemmaleigh
Copy link
Contributor

I'd like to revise this to:

Make sure text on a coloured background is legible.

To meet WCAG2 Level AA, you need to make sure the:

  • font size is at least 18px, or 14px bold
  • contrast ratio is 3:1

I've run this past the content designers on the Service Manual team.

@sanjaypoyzer let me know if you're happy to amend and squash those two commits, otherwise I can.

@edwardhorsford
Copy link
Contributor

@gemmaleigh Does that mean that essentially services shouldn't use core-19 in those boxes? (since the font size goes down to 16px on mobile).

@sanjaypoyzer
Copy link
Author

Yeah sure, that looks clearer. Will just wait for the clarification on the core-19 point before doing it.

@gemmaleigh
Copy link
Contributor

Yes, the example as-is would fail WCAG2 Level AA for smaller viewports, where .core-19 for body text at 19px decreases to 16px.

If we don't intend to change the colour of the background - then the font size can either be increased, or the 19px white text on a turquoise background could use .bold-19 which would pass.

@sanjaypoyzer
Copy link
Author

Should we add that to the guidance as well, or do you think it's clear enough to be inferred?

@gemmaleigh
Copy link
Contributor

This was added in #481, closing as this has now been resolved.

@gemmaleigh gemmaleigh closed this Jun 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants