Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update max for date pattern to include this year #175

Merged
merged 1 commit into from
Feb 8, 2016

Conversation

gemmaleigh
Copy link
Contributor

This should be 2016, and fixes #174.

cc. @robinwhittleton, @joelanman, @henryhadlow.

@joelanman
Copy link
Contributor

does this highlight its a fragile thing to even use? Services would have to remember to update every year - seems likely that it'll sometimes be broken.

@henryhadlow
Copy link

I was thinking the same thing. Could we just set it to longtime in the
future and then have additional validation post-submission?

Also, it should be min="1899"

https://en.m.wikipedia.org/wiki/List_of_the_verified_oldest_people

On 8 February 2016 at 13:16, Joe Lanman [email protected] wrote:

does this highlight its a fragile thing to even use? Services would have
to remember to update every year - seems likely that it'll sometimes be
broken.


Reply to this email directly or view it on GitHub
#175 (comment)
.

Henry Hadlow
Product Manager
GOV.UK Notify
https://gds.blog.gov.uk/2015/10/05/status-tracking-making-it-easy-to-keep-users-informed/
• petition.parliament.uk
Government Digital Service https://gds.blog.gov.uk/

@robinwhittleton
Copy link
Contributor

Services would presumably make it dynamic (e.g. <%= Time.now.year %> in Rails). As for oldest people, I can imagine some sort of historical lookup service. I randomly worked on a Australian convict search system for local government a while back and while this doesn’t have birth date specifically there’s no reason why it couldn’t have.

robinwhittleton added a commit that referenced this pull request Feb 8, 2016
Update max for date pattern to include this year
@robinwhittleton robinwhittleton merged commit ac4bff2 into master Feb 8, 2016
@joelanman
Copy link
Contributor

what's the user need for a max date?

@gemmaleigh gemmaleigh deleted the fix-date-range-for-dob-example branch April 7, 2017 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

using cursor keys, you can't get 2015 or 2016 in the year input
4 participants