Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing 2/3 width grid wrappers to example pages #173

Merged
merged 1 commit into from
Feb 8, 2016

Conversation

gemmaleigh
Copy link
Contributor

All main content should sit in a 2/3 column grid.
Add .grid-row and .column-two-thirds divs where they are missing.

This is most noticeable on the Errors and validation pages - the error message summary box should also be constrained by a wrapper which is 2/3 of the page width.

Screenshot before:

before - example form validation errors gov uk elements

Screenshots after:

example form validation errors gov uk elements

2 example form validation errors gov uk elements

All content should sit in a 2/3 column grid.
Add the wrapping grid-row and column-width divs where they are missing.
@robinwhittleton
Copy link
Contributor

LGTM

robinwhittleton added a commit that referenced this pull request Feb 8, 2016
Add missing 2/3 width grid wrappers to example pages
@robinwhittleton robinwhittleton merged commit c052dfa into master Feb 8, 2016
@gemmaleigh gemmaleigh deleted the add-grid-layout-to-example-pages branch April 7, 2017 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants