Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing list classes #140

Merged
merged 3 commits into from
Dec 8, 2015
Merged

Fix missing list classes #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
553dad9
Add list classes for bulleted lists
gemmaleigh Dec 8, 2015
3424a0a
Remove default list style within example boxes
gemmaleigh Dec 8, 2015
6d5c225
Add missing list classes to Icons example page
gemmaleigh Dec 8, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions public/sass/elements-page.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,12 @@
color: $hm-government;
}

// Remove default list style within examples
ol,
ul {
list-style-type: none;
}

// Fix grid layout within example boxes for IE7 and below
// where box-sizing isn't supported: http://caniuse.com/#search=box-sizing
@mixin example-box-column($width) {
Expand Down
8 changes: 4 additions & 4 deletions views/examples/example_icons.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ <h1 class="heading-xlarge">

<div class="column-third">
<h2 class="heading-medium">Step icons</h2>
<ol class="example-icon-list">
<ol class="list example-icon-list">
<li><i class="icon icon-step-1"></i> <p>icon-step-1.png</p></li>
<li><i class="icon icon-step-2"></i> <p>icon-step-2.png</p></li>
<li><i class="icon icon-step-3"></i> <p>icon-step-3.png</p></li>
Expand All @@ -52,7 +52,7 @@ <h2 class="heading-medium">Step icons</h2>

<div class="column-third">
<h2 class="heading-medium">Step circles</h2>
<ol class="example-icon-list">
<ol class="list example-icon-list">
<li> <span class="circle circle-step">1</span> <span class="circle circle-step-large">1</span> </li>
<li> <span class="circle circle-step">2</span> <span class="circle circle-step-large">2</span> </li>
<li> <span class="circle circle-step">3</span> <span class="circle circle-step-large">3</span> </li>
Expand All @@ -72,7 +72,7 @@ <h2 class="heading-medium">Step circles</h2>

<div class="column-third">
<h2 class="heading-medium">Icons</h2>
<ul class="example-icon-list">
<ul class="list example-icon-list">
<li>
<i class="icon icon-calendar"></i>
<p>icon-calendar.png</p>
Expand All @@ -99,7 +99,7 @@ <h2 class="heading-medium">Icons</h2>

<div class="column-third">
<h2 class="heading-medium">White or semi-transparent icons</h2>
<ul class="example-icon-list example-icon-list-background">
<ul class="list example-icon-list example-icon-list-background">
<li>
<i class="icon icon-pointer"></i>
<p>icon-pointer.png</p>
Expand Down
2 changes: 1 addition & 1 deletion views/guide_icons_images.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ <h3 class="heading-medium" id="images">Images</h3>
</div>

<h3 class="heading-medium" id="examples">Examples</h3>
<ul>
<ul class="list list-bullet">
<li><a href="{{site.baseurl}}/icons-images/example-icons/">Example page: Icons in the GOV.UK frontend toolkit</a></li>
</ul>

Expand Down