Copy base styles from govuk template #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://raw.githubusercontent.com/alphagov/govuk_template/master/source/ assets/stylesheets/_accessibility.scss
Remove any styles which relate to the govuk template header, if not using the govuk_template - these won’t be required.
Remove helper classes which are used only by the govuk_template: .group (clearfix) .content-fixed and .shim .ir (for image replacement) .invisible .skiplink
- Move helper class .hidden to the helpers partial - Remove .visuallyhidden from the base partial as this already exists in elements/helpers
- Group styles for focus, links and external links - Group all rules defined for html and body elements - Use Sass comment format
If the govuk_template isn’t being used - there isn’t by default a search box in the header. Remove these styles as they should only be set once, in normalize.css, as if required.
Ensure the partial is commented out, as these styles are already set by govuk_template - there’s no need to duplicate in govuk_elements.
|
LGTM |
robinwhittleton
added a commit
that referenced
this pull request
Dec 4, 2015
…plate Copy base styles from govuk template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For users who want to use govuk_frontend_toolkit and govuk_elements, to make use of GOV.UK design patterns.
govuk_elements has the govuk_template and govuk_frontend_toolkit as dependencies.
To use govuk_elements without the govuk_template, any base styles (which are currently set by the template) are copied to the new partial
_base.scss.Ideally, this file would use Normalize.css as its starting point, which can then be customised to meet the design's requirements.
cc. @fofr, @robinwhittleton.