Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back link wrong colour when focused #540

Closed
edwardhorsford opened this issue Aug 7, 2017 · 5 comments
Closed

Back link wrong colour when focused #540

edwardhorsford opened this issue Aug 7, 2017 · 5 comments

Comments

@edwardhorsford
Copy link
Contributor

The back link changes to our standard govuk-blue when focused - I presume it should stay black.

Screenshot:
screen shot 2017-08-07 at 11 13 37

@kr8n3r
Copy link

kr8n3r commented Aug 8, 2017

seem that all of our links when focused maintain their default gov.uk colour

a:link:focus {
    color: #005798;
}

and there is no exception for back link. if the consensus is to keep in black on focus that we can add it in.

@NickColley
Copy link
Contributor

If you remove the border property's references to the black, it'll pick up the currentColor and end up looking like:

screen shot 2017-08-08 at 11 00 22

@edwardhorsford
Copy link
Contributor Author

I suspect this regression was introduced by this pr: alphagov/govuk_template#272

I think it should stay black. The reason we added the different blue focus colour was so that the contrast met our standards - this isn't a problem with the black links.

@kr8n3r
Copy link

kr8n3r commented Aug 8, 2017

got to love the generic a:link:focus ...

@gemmaleigh
Copy link
Contributor

This was fixed by #544.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants