Do not report infinite or NaN sidekiq thresholds in healthcheck

alphagov · Sep 26, 2018 · aa20955 · aa20955
1 parent b6b63d9
commit aa20955
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/lib/govuk_app_config/govuk_healthcheck/sidekiq_queue_check.rb b/lib/govuk_app_config/govuk_healthcheck/sidekiq_queue_check.rb
@@ -41,7 +41,7 @@ def details
             thresholds: {
               critical: critical_threshold(queue: name),
               warning: warning_threshold(queue: name),
-            },
+            }.select { |_, val| !(val.to_f.infinite? || val.to_f.nan?) },
           }
         end,
       }

diff --git a/spec/lib/govuk_healthcheck/sidekiq_queue_check_spec.rb b/spec/lib/govuk_healthcheck/sidekiq_queue_check_spec.rb
@@ -51,6 +51,22 @@
     end
   end
 
+  context "NaNs and infinities" do
+    subject { TestQueueCheck.new({ queue: 0 }, Float::INFINITY, Float::NAN) }
+
+    it_behaves_like "a healthcheck"
+
+    its(:status) { is_expected.to eq(:ok) }
+    its(:message) { is_expected.to match(/below the critical and warning thresholds/) }
+    its(:details) do
+      is_expected.to match(
+        queues: {
+          queue: hash_including(value: 0, thresholds: {})
+        }
+      )
+    end
+  end
+
   class TestQueueCheck < GovukHealthcheck::SidekiqQueueCheck
     def initialize(queues, warning_threshold, critical_threshold, name = :test)
       @queues = queues