This repository has been archived by the owner on Sep 17, 2021. It is now read-only.
Add govuk showhide content #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to test GOVUK.ShowHideContent(), which is to be added to the govuk_frontend_toolkit.
Related PR for the front end toolkit: alphagov/govuk_frontend_toolkit#305 Related PR for elements: alphagov/govuk_elements#287
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the JavaScript in
application.jsand replaces theshowHideContentfunctionality with a newer version (to be added to the govuk_frontend_toolkit), I have duplicated this here for testing.Later it can be included in this project via the govuk_frontend_toolkit and the files in /app/assets/javascripts/govuk/ can be removed.
The test cases which will be affected by this are those which conditionally reveal content - for both radio buttons and checkboxes.
To be tested:
Checkboxes:
http://localhost:3000/patterns/checkboxes-reveal/01/
Radio buttons
http://localhost:3000/patterns/radio-buttons-reveal/01/