Skip to content

Commit

Permalink
Resolve linting alerts
Browse files Browse the repository at this point in the history
  • Loading branch information
kevindew committed Feb 22, 2024
1 parent bb76316 commit 6781807
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions lib/govuk_ab_testing/abstract_helpers.rb
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def with_variant(args)
end

def setup_ab_variant(ab_test_name, variant, dimension = 300)
ab_test = AbTest.new(ab_test_name, dimension: dimension)
ab_test = AbTest.new(ab_test_name, dimension:)
acceptance_test_framework.set_header(ab_test.request_header, variant)
end

Expand Down Expand Up @@ -73,7 +73,7 @@ def assert_page_not_tracked_in_ab_test(ab_test_name)
end

def assert_page_tracked_in_ab_test(ab_test_name, variant, dimension)
ab_test = AbTest.new(ab_test_name, dimension: dimension)
ab_test = AbTest.new(ab_test_name, dimension:)

ab_test_meta_tags =
acceptance_test_framework.analytics_meta_tags_for_test(ab_test.name)
Expand Down
2 changes: 1 addition & 1 deletion lib/govuk_ab_testing/minitest_assertions.rb
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ def assert_has_size(enumerable:, size:, error_message:)
end

def assert_is_empty(enumerable:, error_message:)
assert_has_size(enumerable: enumerable, size: 0, error_message: error_message)
assert_has_size(enumerable:, size: 0, error_message:)
end

def assert_not_blank(string:, error_message:)
Expand Down
4 changes: 2 additions & 2 deletions spec/acceptance_tests/capybara_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
describe GovukAbTesting::AcceptanceTests::Capybara do
let(:capybara_acceptance_test) do
driver = double(options: {}, header: true)
page = double("Capybara::Session", driver: driver)
scope = double(page: page)
page = double("Capybara::Session", driver:)
scope = double(page:)

described_class.new(scope)
end
Expand Down

0 comments on commit 6781807

Please sign in to comment.