Bump toolkit and standard / nunjucks, and tidy package.json a bit #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 16, 2016 10:50
And fix reported issues: just spacing.
gemmaleigh
reviewed
Dec 16, 2016
| "marked": "^0.3.6", | ||
| "minimist": "0.0.8", |
There was a problem hiding this comment.
This isn't being used to set the port anymore, but looks like it might be useful, if we can keep it in - in case others are using it.
gemmaleigh
suggested changes
Dec 16, 2016
- consolidate was added to help replace mu2 for mustache rendering - hogan.js was also in there for mustache rendering
robinwhittleton
force-pushed
the
bump-fet
branch
from
53c5f0c to
6685822
Compare
robinwhittleton
pushed a commit
that referenced
this pull request
Dec 16, 2016
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings standard, nunjucks and govuk_frontend_toolkit up to the latest, and removes some older unused packages from package.json. Without a comprehensive test suite it’s always possible that removing stuff might be a problem, but: