Make analytics non-deploy specific #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardhorsford
force-pushed
the
analytics-fix
branch
from
b3b1190 to
447122b
Compare
|
looks good to me |
rpowis
pushed a commit
to hmrc/govuk_prototype_kit
that referenced
this pull request
Jan 31, 2017
# 4.18.1 - Fix error in IE - remove trailing comma from shimLinksWithButtonRole JavaScript ([PR alphagov#323](alphagov/govuk_frontend_toolkit#323)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr amends #320 and works on #322 so that tracking code tied to the app. We don't want other users of the kit to use our tracking code - they should use their own if they want tracking.
Since tracking codes are deploy specific, it's better if it comes from environment.
This pr: