Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unbranded styles override GDS Transport #256

Closed
alextea opened this issue Oct 4, 2016 · 1 comment · Fixed by #270
Closed

Unbranded styles override GDS Transport #256

alextea opened this issue Oct 4, 2016 · 1 comment · Fixed by #270

Comments

@alextea
Copy link
Contributor

alextea commented Oct 4, 2016

Including the unbranded partial in application.scss (introduced in da73ce4) overrides the $toolkit-font-stack for all subsequent rules.

Any styles that are added after the partial include using the typography mixins will use the unbranded font stack instead of GDS Transport.
@gemmaleigh gemmaleigh mentioned this issue Oct 11, 2016
Merged
@gemmaleigh
Copy link
Contributor

#270 fixes this.

@gemmaleigh gemmaleigh mentioned this issue Oct 25, 2016
Merged
gemmaleigh added a commit that referenced this issue Oct 25, 2016
@gemmaleigh
Bump govuk_template_jinja to 0.19.0
bdf7d4f 
https://github.com/alphagov/govuk_template/blob/master/CHANGELOG.md

- Remove external link styles (PR #231)
- Remove extraneous copy of HTML5shiv that wasn’t being used (PR #254)
- Update govuk_frontend_toolkit to latest version (PR #256)
gemmaleigh added a commit that referenced this issue Oct 25, 2016
@gemmaleigh
Bump govuk_template_jinja to 0.19.0
0162527 
https://github.com/alphagov/govuk_template/blob/master/CHANGELOG.md

- Remove external link styles (PR #231)
- Remove extraneous copy of HTML5shiv that wasn’t being used (PR #254)
- Update govuk_frontend_toolkit to latest version (PR #256)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix toolkit font stack overrides alphagov/govuk-prototype-kit
2 participants
@gemmaleigh @alextea