Merge pull request #299 from alphagov/andymantell-basic-sanity-check-…

…test-suite

Basic sanity check test suite

.travis.yml

@@ -1,10 +1,12 @@
 language: node_js
 node_js:
 - 4.0
+- 6.0
+before_install:
+- npm install -g mocha
 install:
 - npm install
 script:
-- gulp test
 - npm test
 after_success:
 - "./create-release-tag.sh"

gulp/tasks.js

@@ -5,7 +5,7 @@
 */
 
 var gulp = require('gulp')
-var gutil = require('gulp-util')
+var mocha = require('gulp-mocha')
 var runSequence = require('run-sequence')
 
 gulp.task('default', function (done) {
@@ -35,7 +35,18 @@ gulp.task('watch', function (done) {
                'watch-assets', done)
 })
 
-gulp.task('test', function (done) {
-  gutil.log('Test that the app runs')
-  done()
+gulp.task('test', function () {
+  runSequence('generate-assets',
+              'mocha')
+})
+
+gulp.task('mocha', function () {
+  return gulp.src(['test/**/*.js'], { read: false })
+        .pipe(mocha({ reporter: 'spec' }))
+        .once('error', () => {
+          process.exit(1)
+        })
+        .once('end', () => {
+          process.exit()
+        })
 })

package.json

@@ -9,7 +9,7 @@
   "scripts": {
     "start": "node start.js",
     "lint": "standard",
-    "test": "npm run lint"
+    "test": "gulp test && npm run lint"
   },
   "dependencies": {
     "basic-auth": "^1.0.3",
@@ -42,5 +42,9 @@
     "serve-favicon": "2.3.0",
     "standard": "^7.1.2",
     "sync-request": "^3.0.1"
+  },
+  "devDependencies": {
+    "gulp-mocha": "^3.0.1",
+    "supertest": "^2.0.0"
   }
 }

server.js

@@ -206,3 +206,5 @@ utils.findAvailablePort(app, function (port) {
     })
   }
 })
+
+module.exports = app

test/mocha.opts

@@ -0,0 +1 @@
+--recursive

test/spec/sanity-checks.js

@@ -0,0 +1,33 @@
+/* eslint-env mocha */
+var request = require('supertest')
+var app = require('../../server.js')
+var path = require('path')
+var fs = require('fs')
+var assert = require('assert')
+
+/**
+ * Basic sanity checks on the dev server
+ */
+describe('The prototype kit', function () {
+  it('should generate assets into the /public folder', function () {
+    assert.doesNotThrow(function () {
+      fs.accessSync(path.resolve(__dirname, '../../public/javascripts/application.js'))
+      fs.accessSync(path.resolve(__dirname, '../../public/images/favicon.ico'))
+      fs.accessSync(path.resolve(__dirname, '../../public/stylesheets/application.css'))
+    })
+  })
+
+  it('should send with a well formed response for the index page', function (done) {
+    request(app)
+      .get('/')
+      .expect('Content-Type', /text\/html/)
+      .expect(200)
+      .end(function (err, res) {
+        if (err) {
+          done(err)
+        } else {
+          done()
+        }
+      })
+  })
+})