Merge pull request #2399 from alphagov/fix-non-expired-session-cleanup

Stop accidentally cleaning up non-expired sessions
alphagov · Feb 28, 2024 · 75f9623 · 75f9623
2 parents dcf4429 + 66b4cfe
commit 75f9623
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/lib/session-file-store.js b/lib/session-file-store.js
@@ -11,12 +11,11 @@ class FileStore extends Store {
   }
 
   async set (sessionId, session, callback = noop) {
-    let storedSessionId
     try {
       // Delete any expired sessions before creating a new session
       const storedSessionFiles = await fse.readdir(this.path)
       await Promise.all(storedSessionFiles.map(async sessionFile => {
-        storedSessionId = sessionFile.replace('.json', '')
+        const storedSessionId = sessionFile.replace('.json', '')
         try {
           const storedSession = await fse.readJson(path.join(this.path, sessionFile))
           if (isExpired(storedSession)) {