Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve reliability of deploy image workflows #2812

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

theseanything
Copy link
Contributor

@theseanything theseanything commented Dec 3, 2024

This PR adds:

  • limits the parallel execution for deploy image workflow. Prevent the race condition of multiple workflows trying to commit at the same time
  • add automatic retries

https://argo-workflows.readthedocs.io/en/latest/synchronization/#workflow-level-synchronization

This workflow requires commiting to git repository, which can fail as
there is a race condition when multiple workflow push, after another
workflow has pulled. Executing these workflows in sequential order
should prevent these failures.
This allows an automatic retry incase of any external failures.
@theseanything theseanything requested a review from a team December 3, 2024 10:50
@theseanything theseanything merged commit 9ea7609 into main Dec 3, 2024
4 checks passed
@theseanything theseanything deleted the improve-reliability-of-deploy-image branch December 3, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants