Defend tables against GOV.UK Elements code #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using Elements and GOV.UK Frontend together, tables behave differently, we need to force the original behaviour of tables to allow for settting the font size on the root element, which is how we recommend users to adjust the font-size of their tables.
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-983
36degrees
approved these changes
Sep 6, 2018
NickColley
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the example in our review application, we set an override class onto the table to force the text to be smaller (16px), when including GOV.UK Elements alongside GOV.UK Frontend that override no longer works since the headers and cells are set to 19px.
This pull request forces headers and cells to be inherited when using GOV.UK Frontend with GOV.UK Elements.