Date Input to use inline-block #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-938
36degrees
reviewed
Aug 3, 2018
| @@ -10,18 +10,17 @@ | |||
| @include govuk-exports("govuk/component/date-input") { | |||
| .govuk-date-input { | |||
| @include govuk-clearfix; | |||
| font-size: 0; | |||
There was a problem hiding this comment.
I think this could do with a comment explaining why it's needed / what it's doing.
dashouse
force-pushed
the
date-input-component-inline-block
branch
from
d05746b
to
3c32b7a
Compare
36degrees
reviewed
Aug 3, 2018
NickColley
force-pushed
the
date-input-component-inline-block
branch
from
3c32b7a
to
4cb5098
Compare
kr8n3r
force-pushed
the
date-input-component-inline-block
branch
from
4cb5098
to
2e6e85d
Compare
|
resolved CHANGELOG conflict |
36degrees
approved these changes
Aug 13, 2018
|
merged on behalf of @dashouse |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Date Input to use inline block not floats.
When we give support to people wanting to add an element next to an input we often tell them to use
govuk-!-display-inline-block. It would be good if we followed the same method for components too.This should also make it easier to insert optional separators in between the fields in a future update.
I've also removed the extra 2px padding on the label, no longer needed.