Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only underline logo on hover (with custom colours) #926

Merged
merged 2 commits into from
Jul 24, 2018
Merged

Only underline logo on hover (with custom colours) #926

merged 2 commits into from
Jul 24, 2018

Commits on Jul 24, 2018

  1. Only underline logo on hover (with custom colours) 

    Because all borders will become text colour when a user overrides colour in their browser, the transparent border will become always visible.

By only applying the border on hover we avoid this which means we get the correct behaviour even when colours are customised. The layout is not affected because we offset the additional border with a negative margin.

Removing any border-color attribute means that we'll use the currentColor for the border - making this explicit results in IE8 ignoring the rule because it doesn't understand the currentColor variable.
    @36degrees
    36degrees committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    1d6b0f6 View commit details
    Browse the repository at this point in the history

  2. Document in CHANGELOG

    @36degrees
    36degrees committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    6ce51bf View commit details
    Browse the repository at this point in the history