Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use get-function to call Sass functions #919

Merged
merged 2 commits into from
Jul 19, 2018
Merged

Use get-function to call Sass functions #919

merged 2 commits into from
Jul 19, 2018

Conversation

alex-ju
Copy link
Contributor

@alex-ju alex-ju commented Jul 19, 2018

Updates src/tools/_font_url.scss and src/tools/_image_url.scss to use get-function instead of passing a string directly.

get-function($string) is deprecated and adds warnings to the log:

DEPRECATION WARNING: Passing a string to call() is deprecated and will be illegal
in Sass 4.0. Use call(get-function("image-url")) instead.

Fixes #918

36degrees
36degrees reviewed Jul 19, 2018
View reviewed changes
Copy link
Contributor

@36degrees 36degrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alex-ju! Would you mind adding an entry to /CHANGELOG.md under 'Fixes' for the next release?

36degrees
36degrees approved these changes Jul 19, 2018
View reviewed changes
Copy link
Contributor

@36degrees 36degrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ace, thanks @alex-ju!

This will need a second review from someone from the team then we can get this merged 👍

NickColley
NickColley approved these changes Jul 19, 2018
View reviewed changes
Copy link
Contributor

@NickColley NickColley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Alex this is top.

@36degrees 36degrees merged commit c809239 into alphagov:master Jul 19, 2018
@alex-ju alex-ju deleted the use-sass-get-function branch July 19, 2018 13:03
@kr8n3r kr8n3r added this to the [NEXT] milestone Jul 19, 2018
@kr8n3r kr8n3r mentioned this pull request Jul 26, 2018
Merged
@36degrees 36degrees mentioned this pull request Aug 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickColley NickColley NickColley approved these changes

@36degrees 36degrees 36degrees approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@alex-ju @36degrees @NickColley @kr8n3r