Remove bottom margin on checkbox and radio labels #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the labels, legends and headings work margin-bottom: 5px was added to govuk-label. This was intended for labels above text inputs but has been applied to checkbox and radios too. So govuk-checkboxes__label and govuk-radios__label need to have margin-bottom: 0; applied to override this.
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-883
|
Looks good to me 👍 |
36degrees
approved these changes
Jul 11, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the labels, legends and headings work margin-bottom: 5px was added to
govuk-label.This was intended for labels above text inputs but has been applied to checkbox and radios labels too.
So
govuk-checkboxes__labelandgovuk-radios__labelneed to havemargin-bottom: 0;applied to override this.https://trello.com/c/aplfBBBF/1197-checkbox-and-radio-labels-should-not-have-a-bottom-margin
Fixes: #881