-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow additional label classes in radios and checkboxes macros #880
Conversation
I think we might need a quick discussion about whether bold radio labels is something with a definite need. For example you could differentiate with normal labels, and grey hint text. jani added: as done here https://reply-jury-summons-trial.service.gov.uk/steps/00-responder-type |
2e92471
to
212bb0e
Compare
the second example is interesting because it puts the hint inside the label. I think that just highlights that we should probably discuss what the best way to use radio labels is |
f035b2b
to
1ae9cff
Compare
sure, it puts in there as it was (is) the only way to do it. |
We used the bold to contrast with the hints better I think. |
47179f7
to
edfb77f
Compare
edfb77f
to
3c9a3bf
Compare
3c9a3bf
to
ec6aa13
Compare
we have decided to go ahead with this. code review needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @igloosi!
At the moment the label classes on radio and checkbox items are fixed. There has been interest to be able to modify them, to say make the label bold.
When combined with ability to pass through then hint, the macros will be much more customisable
This PR:
Screenshot