Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow additional label classes in radios and checkboxes macros #880

Merged
merged 4 commits into from
Jul 26, 2018

Conversation

kr8n3r
Copy link

@kr8n3r kr8n3r commented Jul 6, 2018

At the moment the label classes on radio and checkbox items are fixed. There has been interest to be able to modify them, to say make the label bold.

When combined with ability to pass through then hint, the macros will be much more customisable

This PR:

  • Updates the component template
  • Adds a test to check for the additional label class
  • Updates READMEs

Screenshot

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-880 July 6, 2018 17:02 Inactive
@kr8n3r kr8n3r changed the title Allow label classes in radios and checkboxes Allow additional label classes in radios and checkboxes Jul 6, 2018
@kr8n3r kr8n3r changed the title Allow additional label classes in radios and checkboxes Allow additional label classes in radios and checkboxes macros Jul 6, 2018
@joelanman
Copy link
Contributor

joelanman commented Jul 6, 2018

I think we might need a quick discussion about whether bold radio labels is something with a definite need. For example you could differentiate with normal labels, and grey hint text.

jani added: as done here https://reply-jury-summons-trial.service.gov.uk/steps/00-responder-type

@kr8n3r kr8n3r force-pushed the allow-label-classes-in-radios-and-checkboxes branch from 2e92471 to 212bb0e Compare July 6, 2018 19:21
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-880 July 6, 2018 19:21 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-880 July 6, 2018 19:25 Inactive
@joelanman
Copy link
Contributor

the second example is interesting because it puts the hint inside the label. I think that just highlights that we should probably discuss what the best way to use radio labels is

@kr8n3r kr8n3r force-pushed the allow-label-classes-in-radios-and-checkboxes branch from f035b2b to 1ae9cff Compare July 6, 2018 19:41
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-880 July 6, 2018 19:42 Inactive
@kr8n3r
Copy link
Author

kr8n3r commented Jul 6, 2018

sure, it puts in there as it was (is) the only way to do it.
but yeah, discuss

@NickColley
Copy link
Contributor

We used the bold to contrast with the hints better I think.

@NickColley NickColley added feature request User requests a new feature and removed enhancement labels Jul 13, 2018
@kr8n3r kr8n3r force-pushed the allow-label-classes-in-radios-and-checkboxes branch 5 times, most recently from 47179f7 to edfb77f Compare July 19, 2018 08:34
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-880 July 24, 2018 08:30 Inactive
@kr8n3r kr8n3r force-pushed the allow-label-classes-in-radios-and-checkboxes branch from edfb77f to 3c9a3bf Compare July 25, 2018 08:11
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-880 July 25, 2018 08:11 Inactive
@kr8n3r kr8n3r force-pushed the allow-label-classes-in-radios-and-checkboxes branch from 3c9a3bf to ec6aa13 Compare July 25, 2018 10:17
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-880 July 25, 2018 10:18 Inactive
@kr8n3r
Copy link
Author

kr8n3r commented Jul 26, 2018

we have decided to go ahead with this. code review needed

Copy link
Contributor

@36degrees 36degrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @igloosi!

@kr8n3r kr8n3r merged commit 0be2b8c into master Jul 26, 2018
@kr8n3r kr8n3r deleted the allow-label-classes-in-radios-and-checkboxes branch July 26, 2018 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request User requests a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants