Set display:block on main wrapper
#863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-863
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-863
36degrees
reviewed
Jul 3, 2018
src/objects/_main-wrapper.scss
Outdated
| @@ -19,6 +19,8 @@ | |||
| @mixin govuk-main-wrapper { | |||
| @include govuk-responsive-padding(6, "top"); | |||
| @include govuk-responsive-padding(6, "bottom"); | |||
| // IE11 supports `main` but doesn't set it to block without HTML5shiv | |||
There was a problem hiding this comment.
As far as I know html5shiv isn't involved here - IE11 does support the <main> element 'natively', it's just not styled correctly. The shiv is only invoked for Internet Explorer 6-9 according to their readme.
| @@ -23,6 +23,11 @@ | |||
|
|
|||
| 🔧 Fixes: | |||
|
|
|||
| - Apply `display:block` to `.govuk-main-wrapper` | |||
There was a problem hiding this comment.
If you're intending to add a line-break here, you need to leave a blank line. At the minute it wraps onto one line and reads like this:
Apply
display:blockto.govuk-main-wrapperIn IE11mainelement is set todisplay:inlineso padding an margins aren't applied.
Also, should be and instead of an.
Because the main element is not recognized – meaning it's not defined in IE's default style sheet, so it uses CSS initial value, which is inline.
kr8n3r
force-pushed
the
fix-main-wrapper-ie11
branch
from
7ded723
to
3755a98
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-863
kr8n3r
force-pushed
the
fix-main-wrapper-ie11
branch
from
3755a98
to
2f9b437
Compare
This worries me, I would have thought this would have been fixed by the HTML5 shiv? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the main element is not recognised – meaning it's not defined in IE's default style sheet,
so it uses CSS initial value, which is inline.
Fixes: #862