Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link to Crown copyright #824

Merged
merged 3 commits into from
Jun 25, 2018
Merged

Update link to Crown copyright #824

merged 3 commits into from
Jun 25, 2018

Conversation

bevanloon
Copy link
Contributor

Update the link to the Crown copyright so we don't send users on an
unnecessary redirect.

Update the link to the Crown copyright so we don't send users on an
unnecessary redirect.
@kr8n3r
Copy link

kr8n3r commented Jun 22, 2018

hi, @bevanloo thanks for this.

tests are failing as the footer component's readme file hasn't been updated.
could run gulp generate:readme and commit the Readme file as well?

the other tiny thing is to add the pr number where it says PR #N in the CHANGELOG

Bevan Loon added 2 commits June 25, 2018 10:21
Update the footer README to bring it in line with the new code with the
updated Crown copyright link.
Copy link

@kr8n3r kr8n3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome thanks for this

Copy link
Contributor

@NickColley NickColley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work thanks :)

@bevanloon
Copy link
Contributor Author

@igloosi - thanks for the help.

I don't have merge permissions on this one so if someone who does would do the honours please that would be grand :)

@NickColley NickColley merged commit 693af33 into alphagov:master Jun 25, 2018
@kr8n3r kr8n3r added this to the v1.1.0 milestone Jul 4, 2018
@NickColley NickColley mentioned this pull request Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants