Use the correct class name in bold label example #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-784
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-784
36degrees
reviewed
Jun 12, 2018
CHANGELOG.md
Outdated
| @@ -165,6 +165,9 @@ Note: We're not following semantic versioning yet, we are going to talk about th | |||
| and footer (the OGL logo) by marking them as non-focusable elements | |||
| ([PR #774](https://github.com/alphagov/govuk-frontend/pull/774)) | |||
|
|
|||
| - Update CSS modifier class for a bold label | |||
There was a problem hiding this comment.
I don't think I'd know what this meant if I read this without looking at the PR.
What about something like "Use the correct class name in bold label example (govuk-label--s rather than govuk-label--bold)"
There was a problem hiding this comment.
yeah, was a bit optimistic with the title. updated
kr8n3r
force-pushed
the
bol-label-variant
branch
from
fee0fe1
to
f7babee
Compare
kr8n3r
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we talk about a bold label modifier class
https://govuk-frontend-review.herokuapp.com/components/label
which doesn't exist.
It's been replaced by
.govuk-label--sclass.Updated to add the correct modifier class to the yaml file and README
https://govuk-frontend-review-pr-784.herokuapp.com/components/label
Fixes #783