Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the ‘circle shape’ object #782

Merged
merged 2 commits into from
Jun 13, 2018
Merged

Conversation

36degrees
Copy link
Contributor

This is no longer a particularly useful abstraction now that list with step icons has been removed, as it’s only used in one place and includes a lot of very specific styles.

This is no longer a particularly useful abstraction now that list with step icons has been removed, as it’s only used in one place and includes a lot of very specific styles.
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-782 June 12, 2018 11:04 Inactive
Copy link
Contributor

@NickColley NickColley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, after CHANGELOG updates

Copy link

@kr8n3r kr8n3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 subject to changelog entry

@36degrees
Copy link
Contributor Author

@igloosi @NickColley happy with changelog?

@kr8n3r
Copy link

kr8n3r commented Jun 12, 2018

all good

@36degrees 36degrees merged commit b155ae9 into master Jun 13, 2018
@hannalaakso hannalaakso mentioned this pull request Jun 14, 2018
@36degrees 36degrees deleted the remove-circle-object branch July 2, 2018 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants