Fix a couple of IE8 issues #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-737
NickColley
reviewed
May 30, 2018
|
|
||
| // IE8 doesn't seem to like rendering pseudo-elements using @font-faces, | ||
| // so fall back to using any sans-serif font to render the chevron. | ||
| font-family: sans-serif; |
There was a problem hiding this comment.
Is this safe? Browser do weird things, I wonder if picking something stable like helvetica/arial would be good to start with.
There was a problem hiding this comment.
that would be forcing either a default instead of browser/os default combo
That said, our font stack definition is $govuk-nta-light: "nta", Arial, sans-serif;, so going by that we either do sans-serif or Arial, sans-serif
Not sure how up to date this table is https://www.granneman.com/webdev/coding/css/fonts-and-formatting/web-browser-font-defaults/
There was a problem hiding this comment.
Yeah, was thinking we use the current font stack minus nta
There was a problem hiding this comment.
Updated to use Arial, sans-serif.
IE8 doesn't seem to like rendering pseudo-elements using @font-faces, so fall back to using any sans-serif font to render the chevron.
IE8 does not support box-shadow, so use a border instead. For browsers other than IE8 we use a transparent border to support users who override their browser colours, but the intersection of IE8 users who override their browser colours is likely to be negligible, so it should be OK to override this.
36degrees
force-pushed
the
fix-ie8-components
branch
from
0109f2a
to
9bc6d96
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-737
The issue with chevrons was not present in the previous release (as the custom font-face has never worked in IE8 until this release) so does not need to be documented.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buttons
Fix missing button shadow by using a bottom-border in IE8.
Before
After
Breadcrumbs
Fix missing chevrons by falling back to any sans-serif font. IE8 seems to struggle to render pseudo-elements that use a font defined as a
@font-face.Before
After