Add ability to pass explicit names for checkbox items #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add test for explicitly passed ids for checkbox items
kr8n3r
approved these changes
May 24, 2018
NickColley
approved these changes
May 24, 2018
There was a problem hiding this comment.
Wow, Thanks so much @solidgoldpig this PR is great. 👍
For external contributors we need to have a second reviewer from the team but from me this looks great thanks so much.
NickColley
reviewed
May 24, 2018
| @@ -151,6 +151,59 @@ describe('Checkboxes', () => { | |||
| expect($lastLabel.attr('for')).toEqual('custom-2') | |||
| }) | |||
|
|
|||
| it('render explicitly passed item ids', () => { | |||
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#717
Also add test for explicitly passed ids for checkbox items