Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove normalize from /dist builds #699

Merged
merged 2 commits into from
May 16, 2018
Merged

Conversation

NickColley
Copy link
Contributor

@NickColley NickColley commented May 16, 2018

Normalize adds globals that we are not testing for.

Keep the /dist builds consistent with what is in npm by removing this layer.

Fixes #679

Normalize adds globals that we are not testing for.

Keep the /dist builds consistent with what is in npm by removing this layer.

Fixes #679
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-699 May 16, 2018 14:13 Inactive
Copy link
Contributor

@36degrees 36degrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@NickColley NickColley changed the title Remove normalize from /dist builds [Do not merge until release] Remove normalize from /dist builds May 16, 2018
@36degrees
Copy link
Contributor

Why can't this be merged until the release? It won't have any effect until we build:dist right?

@NickColley
Copy link
Contributor Author

Sure, was just trying to make sure I didn't block the release. Can go in.

@NickColley NickColley changed the title [Do not merge until release] Remove normalize from /dist builds Remove normalize from /dist builds May 16, 2018
@NickColley NickColley merged commit c87a3b0 into master May 16, 2018
@NickColley NickColley deleted the remove-normalize-from-dist branch May 16, 2018 15:59
@kr8n3r kr8n3r mentioned this pull request May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants