Remove -webkit-tap-highlight-color from links
#692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-692
36degrees
approved these changes
May 14, 2018
hannalaakso
changed the title
-webkit-tap-highlight-color in links-webkit-tap-highlight-color from links
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-692
hannalaakso
force-pushed
the
remove-webkit-tap-highlighting
branch
from
2cd2487
to
eb607c7
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-692
hannalaakso
force-pushed
the
remove-webkit-tap-highlighting
branch
from
eb607c7
to
ce039b5
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This line appears to have been copied from GOV.UK Template link styles to set
-webkit-tap-highlight-colorto grey after removing it globally. However we are not removing it inhtmlin GOV.UK Frontend so setting the colour here is not necessary.If we DID want to remove
-webkit-tap-highlight-colorin FE in the future I think we'd need more evidence that removing it in is a good idea: it improves accessibility as the user gets instant feedback. GOV.UK Template links to this article from 2010 as the reason for removing it. However we haven't come across the problem described in the article when testing GOV.UK Frontend on iOS and the article doesn't give practical examples we could test against.I also checked the difference between the native iOS
-webkit-tap-highlight-colorand usingrgba($govuk-black, .3)to see if some benefit could be gained from resetting the colour in links. However as the comment for it says the colour "ever-so-slightly darker than the default" so the difference is minimal.Trello: https://trello.com/c/UeF2Dex3/572-revisit-tap-highlighting-overrides-in-govuk-frontend