Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup to publish one package #680

Merged
merged 29 commits into from
May 10, 2018
Merged

Setup to publish one package #680

merged 29 commits into from
May 10, 2018

Conversation

kr8n3r
Copy link

@kr8n3r kr8n3r commented May 2, 2018 •
edited
Loading

This work is the minimum to take the current folder structure into a place where it can be published as one package.

URL: https://govuk-frontend-review-pr-680.herokuapp.com/

Checklist:

  • all files are moved into into root
  • Main folder is packages instead of package
  • Components do not have a package.json
  • Lerna is removed
  • Can be published as @govuk-frontend/govuk-frontend
  • Any documentation that refers to this is updated.
    Note: we have not updated the main readme to avoid providing #instructions that are not yet correct(before this gets shipped)
  • Update any tests/ build pipelines to support this
  • Check build:package and build:dist succeeds
  • updates release scripts

To test run:
npm run build:packages
npm run build:dist

We have tested the release process and consumed the package in the Design System.

Trello ticket: https://trello.com/c/AXKG0aAJ/932-5-setup-to-publish-one-package

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-680 May 2, 2018 07:42 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-680 May 2, 2018 07:58 Inactive
@kr8n3r kr8n3r force-pushed the setup-to-publish-one-package branch from efa2e4a to 4290f75 Compare May 2, 2018 20:44
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-680 May 2, 2018 20:44 Inactive
@kr8n3r kr8n3r force-pushed the setup-to-publish-one-package branch from 4290f75 to 8c3439b Compare May 2, 2018 21:00
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-680 May 2, 2018 21:01 Inactive
@kr8n3r kr8n3r force-pushed the setup-to-publish-one-package branch from 8c3439b to a44e133 Compare May 2, 2018 21:16
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-680 May 2, 2018 21:16 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-680 May 3, 2018 08:32 Inactive
@kr8n3r kr8n3r force-pushed the setup-to-publish-one-package branch from bec4ef7 to 3fe4d17 Compare May 3, 2018 08:46
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-680 May 3, 2018 08:46 Inactive
@kr8n3r kr8n3r force-pushed the setup-to-publish-one-package branch from 3fe4d17 to 7844a77 Compare May 3, 2018 08:56
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-680 May 3, 2018 08:56 Inactive
@kr8n3r kr8n3r force-pushed the setup-to-publish-one-package branch from 7844a77 to d251d4e Compare May 3, 2018 10:10
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-680 May 3, 2018 10:11 Inactive
@kr8n3r kr8n3r force-pushed the setup-to-publish-one-package branch from d251d4e to 562d21a Compare May 3, 2018 10:11
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-680 May 3, 2018 10:12 Inactive
@kr8n3r kr8n3r force-pushed the setup-to-publish-one-package branch from 562d21a to 486d2cf Compare May 3, 2018 10:39
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-680 May 3, 2018 10:39 Inactive
@kr8n3r kr8n3r force-pushed the setup-to-publish-one-package branch from 486d2cf to f44c968 Compare May 3, 2018 11:05
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-680 May 3, 2018 11:05 Inactive
@kr8n3r kr8n3r force-pushed the setup-to-publish-one-package branch from f44c968 to 1e3fcc7 Compare May 3, 2018 11:08
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-680 May 3, 2018 11:08 Inactive
@kr8n3r kr8n3r force-pushed the setup-to-publish-one-package branch from 1e3fcc7 to a300bb7 Compare May 3, 2018 11:12
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-680 May 3, 2018 11:12 Inactive
@kr8n3r kr8n3r force-pushed the setup-to-publish-one-package branch from a300bb7 to 92d4578 Compare May 3, 2018 11:13
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-680 May 3, 2018 11:14 Inactive
@kr8n3r kr8n3r force-pushed the setup-to-publish-one-package branch from 92d4578 to 8289506 Compare May 3, 2018 11:15
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-680 May 3, 2018 11:15 Inactive
@kr8n3r kr8n3r force-pushed the setup-to-publish-one-package branch from 8289506 to b5e4458 Compare May 3, 2018 11:18
Jani Kraner added 18 commits May 10, 2018 16:15
Update gulpfile
6187ac2
Move all folder into root
85689cd
Update app*.scss files to import root govuk*.scss files
7e3946a
Remove redundant govuk*.scss from app/ folder
65c1f0b
Update import paths for partials in govuk*.scss files
5ced94c
Update app layout view to reference updated paths
248d988
Update compile-assets gulp task
1e8ef94
Create a new package.json in package folder
bae6b4b
Updated paths for imported JS
0081099
Remove all component package.json files
93b96ba
No need to filter all package from the list of components
36b5cd4
No longer need to expect package.json in each folder
e26d56f
Expect root files from src/ in package/
18fffad
Update build-after-dist test
e49d6be
Update release scripts and remove redundant
2d17540
Update copy-to-destination gulp task
d9d0beb
Update gitignore
e96d90c
Import all in all-ie8.scss
64b6380
@kr8n3r kr8n3r force-pushed the setup-to-publish-one-package branch from 4f5e4f3 to 05cee96 Compare May 10, 2018 15:16
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-680 May 10, 2018 15:16 Inactive
@kr8n3r kr8n3r force-pushed the setup-to-publish-one-package branch from 05cee96 to 16abddf Compare May 10, 2018 15:19
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-680 May 10, 2018 15:19 Inactive
@kr8n3r
Copy link
Author

kr8n3r commented May 10, 2018 •
edited
Loading

rebased with ALL THE THINGS
and fixed empty __snapshots__ folder in package

@kr8n3r kr8n3r merged commit 5f2bc64 into master May 10, 2018
@NickColley NickColley deleted the setup-to-publish-one-package branch May 10, 2018 15:53
@kr8n3r kr8n3r mentioned this pull request May 11, 2018
Merged
@kr8n3r kr8n3r mentioned this pull request May 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickColley NickColley NickColley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kr8n3r @NickColley @hannalaakso @govuk-design-system-ci