-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify dist folder #673
Merged
Merged
Simplify dist folder #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-673
April 26, 2018 15:47
Inactive
kr8n3r
force-pushed
the
simplify-dist-folder
branch
from
April 26, 2018 15:53
1b6866e
to
8322d3f
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-673
April 26, 2018 15:53
Inactive
kr8n3r
changed the title
WIP: Simplify dist folder
WIP - DO NOT MERGE : Simplify dist folder
Apr 26, 2018
kr8n3r
force-pushed
the
simplify-dist-folder
branch
from
April 27, 2018 07:48
8322d3f
to
6024bc9
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-673
April 27, 2018 07:48
Inactive
kr8n3r
changed the title
WIP - DO NOT MERGE : Simplify dist folder
Simplify dist folder
Apr 27, 2018
Rename it and place it in the base directory
kr8n3r
force-pushed
the
simplify-dist-folder
branch
from
April 27, 2018 14:40
6024bc9
to
921d65a
Compare
NickColley
reviewed
May 1, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great but I don't believe the tests are checking that icons are copied correctly, is this something we want?
true, we never wrote test for copying icons. separate PR? |
@igloosi I'll raise an issue |
NickColley
approved these changes
May 1, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're simplifying the
dist/
folder by removing the component related files as they're currently not useful.This can either be merged before or after next Frontend release
This PR:
dist/
folder contentsall.js
is compiled todist
/To test:
run
npm run build:dist
To test nothing changed in creating
packages/
run
npm run build:packages
Trello ticket: https://trello.com/c/faz4k1Pm/931-2-simplify-distributed-folder-in-govuk-frontend