Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify dist folder #673

Merged
merged 8 commits into from
May 1, 2018
Merged

Simplify dist folder #673

merged 8 commits into from
May 1, 2018

Conversation

kr8n3r
Copy link

@kr8n3r kr8n3r commented Apr 26, 2018

We're simplifying the dist/ folder by removing the component related files as they're currently not useful.

This can either be merged before or after next Frontend release
This PR:

  • Updates the copy task to exclude component related files
  • Updates tests that cover dist/ folder contents
  • Updates build tasks that compile Sass and Javascript to build files in the correct location
  • Insures only all.js is compiled to dist/
  • Updates task that attached version to built assets
  • Updates relevant documentation

To test:
run npm run build:dist

To test nothing changed in creating packages/
run npm run build:packages

Trello ticket: https://trello.com/c/faz4k1Pm/931-2-simplify-distributed-folder-in-govuk-frontend

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-673 April 26, 2018 15:47 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-673 April 26, 2018 15:53 Inactive
@kr8n3r kr8n3r changed the title WIP: Simplify dist folder WIP - DO NOT MERGE : Simplify dist folder Apr 26, 2018
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-673 April 27, 2018 07:48 Inactive
@kr8n3r kr8n3r changed the title WIP - DO NOT MERGE : Simplify dist folder Simplify dist folder Apr 27, 2018
Copy link
Contributor

@NickColley NickColley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great but I don't believe the tests are checking that icons are copied correctly, is this something we want?

@kr8n3r
Copy link
Author

kr8n3r commented May 1, 2018

true, we never wrote test for copying icons. separate PR?

@NickColley
Copy link
Contributor

@igloosi I'll raise an issue

@kr8n3r kr8n3r merged commit e5e2a5d into master May 1, 2018
@kr8n3r kr8n3r deleted the simplify-dist-folder branch May 1, 2018 15:21
@kr8n3r kr8n3r mentioned this pull request May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants