Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Sass imports less broad #617

Merged
merged 23 commits into from
Mar 28, 2018
Merged

Make Sass imports less broad #617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
5916086
Back-link specific individual imports
Mar 22, 2018
14f6795
Breadcrumbs specific imports
Mar 22, 2018
2562313
Button specific imports
Mar 22, 2018
a0235e0
Fieldset specific imports
Mar 22, 2018
5b818f5
Error-message specific imports
Mar 22, 2018
e45f194
Label specific dependencies
Mar 22, 2018
4a3f1c2
Checkboxes specific imports
Mar 22, 2018
5295bbf
Input specific imports
Mar 22, 2018
e89265f
Date-input specific imports
Mar 22, 2018
afc91bf
Details specific imports
Mar 22, 2018
ff466b7
Error-summary specific imports
Mar 22, 2018
d7bc9e6
File-upload specific imports
Mar 22, 2018
a1540ae
Footer specific imports
Mar 22, 2018
5ec363d
Panel specific imports
Mar 23, 2018
93d3af2
Tag specific imports
Mar 23, 2018
d1366fa
Phase-banner specific imports
Mar 23, 2018
7933276
Radios specific imports
Mar 23, 2018
00c14b1
Select specific imports
Mar 23, 2018
aa5bcba
Skip-link specific imports
Mar 23, 2018
f17acd2
Table specific imports
Mar 23, 2018
ef0622e
Textarea specific imports
Mar 23, 2018
d9119fc
Warning-text specific imports
Mar 23, 2018
73ea204
Document in CHANGELOG
Mar 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ Internal:
- Explain npm link
(PR [#624](https://github.com/alphagov/govuk-frontend/pull/624))

- Make Sass imports less broad
(PR [#617](https://github.com/alphagov/govuk-frontend/pull/617))

## 0.0.26-alpha (Breaking release)

Breaking changes:
Expand Down
20 changes: 19 additions & 1 deletion src/back-link/_back-link.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,22 @@
@import "../globals/common";
@import "../globals/tools/exports";
@import "../globals/tools/compatibility";

@import "../globals/settings/colours-palette";
@import "../globals/settings/colours-applied";
@import "../globals/settings/compatibility";
@import "../globals/settings/spacing";
@import "../globals/settings/measurements";

@import "../globals/helpers/media-queries";
@import "../globals/helpers/focusable";
@import "../globals/helpers/shape-arrow";

@import "../globals/helpers/typography";
@import "../globals/settings/typography-font-stacks";
@import "../globals/settings/typography-font";
@import "../globals/settings/typography-responsive";

@import "../globals/core/links";

@include govuk-exports("back-link") {

Expand Down
22 changes: 21 additions & 1 deletion src/breadcrumbs/_breadcrumbs.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,24 @@
@import "../globals/common";
@import "../globals/tools/exports";
@import "../globals/tools/compatibility";

@import "../globals/settings/colours-palette";
@import "../globals/settings/colours-applied";
@import "../globals/settings/compatibility";
@import "../globals/settings/spacing";
@import "../globals/settings/measurements";

@import "../globals/tools/legacy-ie";

@import "../globals/helpers/clearfix";
@import "../globals/helpers/media-queries";
@import "../globals/helpers/focusable";

@import "../globals/helpers/typography";
@import "../globals/settings/typography-font-stacks";
@import "../globals/settings/typography-font";
@import "../globals/settings/typography-responsive";

@import "../globals/core/links";

@include govuk-exports("breadcrumbs") {

Expand Down
23 changes: 22 additions & 1 deletion src/button/_button.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,25 @@
@import "../globals/common";
@import "../globals/tools/exports";
@import "../globals/tools/compatibility";
@import "../globals/tools/legacy-ie";
@import "../globals/tools/iff";

@import "../globals/settings/colours-palette";
@import "../globals/settings/colours-applied";
@import "../globals/settings/compatibility";
@import "../globals/settings/spacing";
@import "../globals/settings/measurements";

@import "../globals/helpers/media-queries";
@import "../globals/helpers/focusable";
@import "../globals/helpers/spacing";
@import "../globals/helpers/device-pixels";

@import "../globals/helpers/typography";
@import "../globals/settings/typography-font-stacks";
@import "../globals/settings/typography-font";
@import "../globals/settings/typography-responsive";

@import "../globals/core/links";

@include govuk-exports("button") {

Expand Down
5 changes: 4 additions & 1 deletion src/checkboxes/_checkboxes.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
@import "../globals/common";
@import "../globals/tools/exports";

@import "../fieldset/fieldset";
@import "../label/label";

@include govuk-exports("checkboxes") {
.govuk-c-checkboxes__item {
Expand Down
5 changes: 4 additions & 1 deletion src/date-input/_date-input.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
@import "../globals/common";
@import "../globals/tools/exports";
@import "../globals/tools/legacy-ie";
@import "../globals/tools/iff";

@import "../label/label";
@import "../input/input";
@import "../error-message/error-message";
Expand Down
17 changes: 16 additions & 1 deletion src/details/_details.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,19 @@
@import "../globals/common";
@import "../globals/tools/exports";
@import "../globals/tools/iff";

@import "../globals/settings/colours-palette";
@import "../globals/settings/colours-applied";
@import "../globals/settings/spacing";
@import "../globals/settings/measurements";

@import "../globals/helpers/media-queries";
@import "../globals/helpers/spacing";
@import "../globals/helpers/shape-arrow";

@import "../globals/helpers/typography";
@import "../globals/settings/typography-font-stacks";
@import "../globals/settings/typography-font";
@import "../globals/settings/typography-responsive";

@include govuk-exports("details") {

Expand Down
13 changes: 12 additions & 1 deletion src/error-message/_error-message.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,15 @@
@import "../globals/common";
@import "../globals/tools/exports";
@import "../globals/tools/iff";

@import "../globals/settings/colours-palette";
@import "../globals/settings/colours-applied";

@import "../globals/helpers/media-queries";

@import "../globals/helpers/typography";
@import "../globals/settings/typography-font-stacks";
@import "../globals/settings/typography-font";
@import "../globals/settings/typography-responsive";

@include govuk-exports("error-message") {
.govuk-c-error-message {
Expand Down
22 changes: 21 additions & 1 deletion src/error-summary/_error-summary.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,24 @@
@import "../globals/common";
@import "../globals/tools/exports";
@import "../globals/tools/compatibility";
@import "../globals/tools/legacy-ie";
@import "../globals/tools/iff";

@import "../globals/settings/colours-palette";
@import "../globals/settings/colours-applied";
@import "../globals/settings/compatibility";
@import "../globals/settings/spacing";
@import "../globals/settings/measurements";

@import "../globals/helpers/media-queries";
@import "../globals/helpers/spacing";
@import "../globals/helpers/focusable";

@import "../globals/helpers/typography";
@import "../globals/settings/typography-font-stacks";
@import "../globals/settings/typography-font";
@import "../globals/settings/typography-responsive";

@import "../globals/core/lists";

@include govuk-exports("error-summary") {

Expand Down
19 changes: 18 additions & 1 deletion src/fieldset/_fieldset.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,21 @@
@import "../globals/common";
@import "../globals/tools/exports";
@import "../globals/tools/legacy-ie";
@import "../globals/tools/iff";

@import "../error-message/error-message";

@import "../globals/settings/spacing";
@import "../globals/settings/measurements";

@import "../globals/helpers/clearfix";
@import "../globals/helpers/spacing";
@import "../globals/helpers/media-queries";

@import "../globals/objects/form-group";





@include govuk-exports("fieldset") {
.govuk-c-fieldset {
Expand Down
9 changes: 8 additions & 1 deletion src/file-upload/_file-upload.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@
@import "../globals/common";
@import "../globals/tools/exports";

@import "../label/label";

@import "../globals/settings/spacing";
@import "../globals/settings/measurements";

@import "../globals/helpers/focusable";

@include govuk-exports("file-upload") {
.govuk-c-file-upload {
Expand Down
21 changes: 20 additions & 1 deletion src/footer/_footer.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,23 @@
@import "../globals/common";
@import "../globals/tools/exports";
@import "../globals/tools/compatibility";
@import "../globals/tools/legacy-ie";
@import "../globals/tools/iff";

@import "../globals/settings/colours-palette";
@import "../globals/settings/colours-applied";
@import "../globals/settings/compatibility";
@import "../globals/settings/spacing";
@import "../globals/settings/measurements";

@import "../globals/helpers/media-queries";
@import "../globals/helpers/focusable";
@import "../globals/helpers/spacing";
@import "../globals/helpers/device-pixels";

@import "../globals/helpers/typography";
@import "../globals/settings/typography-font-stacks";
@import "../globals/settings/typography-font";
@import "../globals/settings/typography-responsive";

@include govuk-exports("footer") {

Expand Down
5 changes: 4 additions & 1 deletion src/input/_input.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
@import "../globals/common";
@import "../globals/tools/exports";
@import "../fieldset/fieldset";
@import "../label/label";
@import "../error-message/error-message";

@import "../globals/helpers/focusable";

@include govuk-exports("input") {
.govuk-c-input {
@include govuk-font-regular-19;
Expand Down
4 changes: 3 additions & 1 deletion src/label/_label.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
@import "../globals/common";
@import "../globals/tools/exports";

@import "../error-message/error-message";

@include govuk-exports("label") {
.govuk-c-label {
Expand Down
16 changes: 15 additions & 1 deletion src/panel/_panel.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,18 @@
@import "../globals/common";
@import "../globals/tools/exports";
@import "../globals/tools/legacy-ie";
@import "../globals/tools/iff";

@import "../globals/settings/colours-palette";
@import "../globals/settings/colours-applied";
@import "../globals/settings/spacing";
@import "../globals/settings/measurements";

@import "../globals/helpers/media-queries";

@import "../globals/helpers/typography";
@import "../globals/settings/typography-font-stacks";
@import "../globals/settings/typography-font";
@import "../globals/settings/typography-responsive";

@include govuk-exports("panel") {

Expand Down
2 changes: 1 addition & 1 deletion src/phase-banner/_phase-banner.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@import "../globals/common";
@import "../globals/tools/exports";
@import "../tag/tag";

@include govuk-exports("phase-banner") {
Expand Down
5 changes: 4 additions & 1 deletion src/radios/_radios.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
@import "../globals/common";
@import "../globals/tools/exports";

@import "../fieldset/fieldset";
@import "../label/label";

@include govuk-exports("radios") {
.govuk-c-radios__item {
Expand Down
11 changes: 10 additions & 1 deletion src/select/_select.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,15 @@
@import "../globals/common";
@import "../globals/tools/exports";

@import "../label/label";

@import "../globals/settings/spacing";
@import "../globals/settings/measurements";

@import "../globals/helpers/focusable";
@import "../globals/helpers/spacing";

@import "../globals/objects/form-group";

@include govuk-exports("select") {
.govuk-c-select {
@include govuk-font-regular;
Expand Down
21 changes: 20 additions & 1 deletion src/skip-link/_skip-link.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,23 @@
@import "../globals/common";
@import "../globals/tools/exports";
@import "../globals/tools/compatibility";
@import "../globals/tools/iff";

@import "../globals/settings/colours-palette";
@import "../globals/settings/colours-applied";
@import "../globals/settings/compatibility";
@import "../globals/settings/spacing";
@import "../globals/settings/measurements";

@import "../globals/helpers/focusable";
@import "../globals/helpers/visually-hidden";
@import "../globals/helpers/media-queries";

@import "../globals/helpers/typography";
@import "../globals/settings/typography-font-stacks";
@import "../globals/settings/typography-font";
@import "../globals/settings/typography-responsive";

@import "../globals/core/links";

@include govuk-exports("skip-link") {
.govuk-c-skip-link {
Expand Down
17 changes: 16 additions & 1 deletion src/table/_table.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,19 @@
@import "../globals/common";
@import "../globals/tools/exports";
@import "../globals/tools/iff";
@import "../globals/tools/px-to-em";

@import "../globals/settings/colours-palette";
@import "../globals/settings/colours-applied";
@import "../globals/settings/spacing";
@import "../globals/settings/measurements";

@import "../globals/helpers/media-queries";
@import "../globals/helpers/spacing";

@import "../globals/helpers/typography";
@import "../globals/settings/typography-font-stacks";
@import "../globals/settings/typography-font";
@import "../globals/settings/typography-responsive";

@include govuk-exports("table") {
.govuk-c-table {
Expand Down
15 changes: 14 additions & 1 deletion src/tag/_tag.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,17 @@
@import "../globals/common";
@import "../globals/tools/exports";
@import "../globals/tools/legacy-ie";
@import "../globals/tools/iff";

@import "../globals/settings/colours-palette";
@import "../globals/settings/colours-applied";
@import "../globals/settings/spacing";

@import "../globals/helpers/media-queries";

@import "../globals/helpers/typography";
@import "../globals/settings/typography-font-stacks";
@import "../globals/settings/typography-font";
@import "../globals/settings/typography-responsive";

@include govuk-exports("tag") {
.govuk-c-tag {
Expand Down
14 changes: 12 additions & 2 deletions src/textarea/_textarea.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,16 @@
@import "../globals/common";
@import "../globals/tools/exports";
@import "../globals/tools/iff";

@import "../label/label";
@import "../error-message/error-message";

@import "../globals/settings/spacing";
@import "../globals/settings/measurements";

@import "../globals/helpers/focusable";
@import "../globals/helpers/spacing";

@import "../globals/objects/form-group";


@include govuk-exports("textarea") {
.govuk-c-textarea {
Expand Down
Loading